From: Ralf Baechle <ralf@linux-mips.org>
To: Ulrich Eckhardt <eckhardt@satorlaser.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses
Date: Wed, 23 Feb 2005 11:19:18 +0000 [thread overview]
Message-ID: <20050223111918.GC6327@linux-mips.org> (raw)
In-Reply-To: <200502230947.53588.eckhardt@satorlaser.com>
On Wed, Feb 23, 2005 at 09:47:53AM +0100, Ulrich Eckhardt wrote:
> PCMCIA controller registers are mapped in an area that requires the upper four
> of the 36 bit addresses, so this can't work without 64 bit physical address
> support. Sick thing is that due to some stupid casts the whole thing compiles
> without warnings even without 64 bit support but of course doesn't run.
> However, that's a topic for a different patch.
> +#if !defined(CONFIG_64BIT_PHYS_ADDR)
> +# error "need 64bit physical address support to access PCMCIA controller"
> +#endif
> +
> #define AU1000_PCMCIA_POLL_PERIOD (2*HZ)
> #define AU1000_PCMCIA_IO_SPEED (255)
> #define AU1000_PCMCIA_MEM_SPEED (300)
No. In drivers/pcmcia/Kconfig do something like:
config PCMCIA_AU1X00
tristate "Au1x00 pcmcia support"
select 64BIT_PHYS_ADDR
depends on SOC_AU1X00 && PCMCIA
Ralf
prev parent reply other threads:[~2005-02-23 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 8:47 [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses Ulrich Eckhardt
2005-02-23 11:19 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050223111918.GC6327@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=eckhardt@satorlaser.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox