clear_user_page in page.h

clear_user_page in page.h

[JP Foster]

Hi all,
I'm building the video4linux drivers as modules and the video-buf driver
can't load as it has no reference to shm_align_mask and
flush_data_cache_page. 

These are needed by asm-mips/page.h for the inline funcs, pages_do_alias
and clear/copy_user_page.
How should shm_align_mask and flush_data_cache_page. be exported to
modules?

Most other asm-xxx/page.h doesn't need any externs, all is #defined
within page.h or files included by it.

Any ideas how I deal with this? Presumably other modules will be 
affected by this.

-- 
jp.foster@exterity.co.uk
Digital Simplicity

Re: clear_user_page in page.h

[Ralf Baechle]

On Tue, Mar 08, 2005 at 01:12:52PM +0000, JP Foster wrote:

> Hi all,
> I'm building the video4linux drivers as modules and the video-buf driver
> can't load as it has no reference to shm_align_mask and
> flush_data_cache_page. 
> 
> These are needed by asm-mips/page.h for the inline funcs, pages_do_alias
> and clear/copy_user_page.
> How should shm_align_mask and flush_data_cache_page. be exported to
> modules?
> 
> Most other asm-xxx/page.h doesn't need any externs, all is #defined
> within page.h or files included by it.
> 
> Any ideas how I deal with this? Presumably other modules will be 
> affected by this.

The code in question should be considered broken anyway but for the
time being until this is actually fixed I'm going to add the two symbol
exports.

  Ralf

Re: clear_user_page in page.h

[JP Foster]

Great, that's what I did here. 
When you say the code in question do you mean the v4l stuff or page.h?

-- 
jp.foster@exterity.co.uk
Digital Simplicity

Re: clear_user_page in page.h

[Ralf Baechle]

On Tue, Mar 08, 2005 at 03:11:20PM +0000, JP Foster wrote:

> Great, that's what I did here. 
> When you say the code in question do you mean the v4l stuff or page.h?

Linux mm.  The (brain-)damage goes beyond page.h.

  Ralf