Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Bryan Althouse" <bryan.althouse@3phoenix.com>
To: "'Ralf Baechle'" <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>
Subject: RE: custom ide driver causes "Badness in smp_call_function"
Date: Thu, 25 Aug 2005 11:26:58 -0400	[thread overview]
Message-ID: <20050825152131Z8225298-3678+7482@linux-mips.org> (raw)
In-Reply-To: <20050824152444.GE2783@linux-mips.org>

Ralf,

Thank you for your help.  
I'm doing MMIO, not PIO, but it looks like your assessment is still valid.
I've been searching for places where ide MMIO is performed with interrupts
disabled.  I got excited when I found these lines in probe_hwif() of
ide-probe.c:

   irqd = hwif->irq;
   if (irqd)
        disable_irq(hwif->irq);

I was not initializing hwif->irq in my driver, so probably the interrupts
were being disabled here, and subsequent lines were causing the SMP badness.
I added the line "hwif->irq = 0" to my driver.  Interrupts are no longer
disabled here, but still I get the SMP badness.  I'll keep looking for other
places where the interrupts might be disabled.  

Does anyone know if the mips/swarm.c driver has this problem with SMP?
Thanks!
  
Bryan

WARNING: multiple messages have this Message-ID (diff)
From: "Bryan Althouse" <bryan.althouse@3phoenix.com>
To: 'Ralf Baechle' <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: RE: custom ide driver causes "Badness in smp_call_function"
Date: Thu, 25 Aug 2005 11:26:58 -0400	[thread overview]
Message-ID: <20050825152131Z8225298-3678+7482@linux-mips.org> (raw)
Message-ID: <20050825152658.kSWkoRguc0DsIEZAbjs1TCQrXRFSaU34hNdC83AhpJY@z> (raw)
In-Reply-To: <20050824152444.GE2783@linux-mips.org>

Ralf,

Thank you for your help.  
I'm doing MMIO, not PIO, but it looks like your assessment is still valid.
I've been searching for places where ide MMIO is performed with interrupts
disabled.  I got excited when I found these lines in probe_hwif() of
ide-probe.c:

   irqd = hwif->irq;
   if (irqd)
        disable_irq(hwif->irq);

I was not initializing hwif->irq in my driver, so probably the interrupts
were being disabled here, and subsequent lines were causing the SMP badness.
I added the line "hwif->irq = 0" to my driver.  Interrupts are no longer
disabled here, but still I get the SMP badness.  I'll keep looking for other
places where the interrupts might be disabled.  

Does anyone know if the mips/swarm.c driver has this problem with SMP?
Thanks!
  
Bryan

  reply	other threads:[~2005-08-25 15:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-23 14:07 custom ide driver causes "Badness in smp_call_function" Bryan Althouse
2005-08-23 14:07 ` Bryan Althouse
2005-08-24 15:24 ` Ralf Baechle
2005-08-25 15:26   ` Bryan Althouse [this message]
2005-08-25 15:26     ` Bryan Althouse
2005-08-25 15:42     ` Ralf Baechle
2005-08-25 21:17       ` Bryan Althouse
2005-08-25 21:17         ` Bryan Althouse
2005-08-26 14:10         ` Ralf Baechle
2005-08-26 14:58           ` Bryan Althouse
2005-08-26 14:58             ` Bryan Althouse
2005-08-26 15:47             ` Alan Cox
2005-08-26 18:05               ` Bryan Althouse
2005-08-26 18:05                 ` Bryan Althouse
2005-08-26 18:16               ` Bryan Althouse
2005-08-26 18:16                 ` Bryan Althouse
2005-08-26 16:28             ` Ralf Baechle
2005-08-26 16:36               ` Bryan Althouse
2005-08-26 16:36                 ` Bryan Althouse
2005-08-26 16:41                 ` Ralf Baechle
2005-09-01 16:15           ` Bryan Althouse
2005-09-01 16:15             ` Bryan Althouse
2005-09-01 16:52             ` Ralf Baechle DL5RB
2005-09-02 12:48           ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050825152131Z8225298-3678+7482@linux-mips.org \
    --to=bryan.althouse@3phoenix.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox