Linux MIPS Architecture development
 help / color / mirror / Atom feed
* uninitialized variable in install_sigtramp()
@ 2005-09-07 13:58 Atsushi Nemoto
  2005-09-07 14:02 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2005-09-07 13:58 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

This is a simple fix.  Removing the 'err' variable entirely could be
alternative fix while the return value of install_sigtramp().

Index: arch/mips/kernel/signal-common.h
===================================================================
RCS file: /home/cvs/linux/arch/mips/kernel/signal-common.h,v
retrieving revision 1.7
diff -u -r1.7 signal-common.h
--- arch/mips/kernel/signal-common.h	14 Jul 2005 12:05:05 -0000	1.7
+++ arch/mips/kernel/signal-common.h	7 Sep 2005 13:38:33 -0000
@@ -182,7 +182,7 @@
 static inline int install_sigtramp(unsigned int __user *tramp,
 	unsigned int syscall)
 {
-	int err;
+	int err = 0;
 
 	/*
 	 * Set up the return code ...
---
Atsushi Nemoto

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: uninitialized variable in install_sigtramp()
  2005-09-07 13:58 uninitialized variable in install_sigtramp() Atsushi Nemoto
@ 2005-09-07 14:02 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2005-09-07 14:02 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Wed, Sep 07, 2005 at 10:58:59PM +0900, Atsushi Nemoto wrote:

> This is a simple fix.  Removing the 'err' variable entirely could be
> alternative fix while the return value of install_sigtramp().

Thanks, I've applied a slightly different fix.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-07 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-07 13:58 uninitialized variable in install_sigtramp() Atsushi Nemoto
2005-09-07 14:02 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox