From: Ralf Baechle <ralf@linux-mips.org>
To: kbaidarov <kbaidarov@dev.rtsoft.ru>
Cc: linux-mips@linux-mips.org
Subject: Re: [patch] db1550: useless memset() call
Date: Fri, 30 Sep 2005 23:19:09 +0100 [thread overview]
Message-ID: <20050930221909.GA14463@linux-mips.org> (raw)
In-Reply-To: <43329632.8070400@dev.rtsoft.ru>
On Thu, Sep 22, 2005 at 03:32:02PM +0400, kbaidarov wrote:
> I've try kernel without memset() on the board - is ok, board boot.
> All drivers works fine. Than I grep the kernel sources:
>
> [root@windmill linux]# grep -nri "memset(irq_desc" arch/
> arch/mips/au1000/common/irq.c:449: memset(irq_desc, 0,
> sizeof(irq_desc));
> arch/mips/ite-boards/generic/irq.c:184: memset(irq_desc, 0,
> sizeof(irq_desc));
> [root@windmill linux]#
>
> Only 2 matches! Does we needs memset() at all?
> And if some one try to initialize irq_desc from start_kernel() before
> arch_init_irq() call, then following arch_init_irq() call discard all that
> initialization.
Exactly, so the initialization is wrong, so I'm removing both calls.
Thanks,
Ralf
prev parent reply other threads:[~2005-10-03 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 11:32 [patch] db1550: useless memset() call kbaidarov
2005-09-30 22:19 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930221909.GA14463@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=kbaidarov@dev.rtsoft.ru \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox