From: kbaidarov <kbaidarov@dev.rtsoft.ru>
To: linux-mips@linux-mips.org
Subject: [patch] db1550: useless memset() call
Date: Thu, 22 Sep 2005 15:32:02 +0400 [thread overview]
Message-ID: <43329632.8070400@dev.rtsoft.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
I've try kernel without memset() on the board - is ok, board boot.
All drivers works fine. Than I grep the kernel sources:
[root@windmill linux]# grep -nri "memset(irq_desc" arch/
arch/mips/au1000/common/irq.c:449: memset(irq_desc, 0, sizeof(irq_desc));
arch/mips/ite-boards/generic/irq.c:184: memset(irq_desc, 0, sizeof(irq_desc));
[root@windmill linux]#
Only 2 matches! Does we needs memset() at all?
And if some one try to initialize irq_desc from start_kernel() before arch_init_irq() call, then following arch_init_irq() call discard all that initialization.
[-- Attachment #2: lm_db1550_irq_desc.patch --]
[-- Type: text/x-patch, Size: 582 bytes --]
Description:
Removes useless memset() call.
Signed-off-by: Konstantin Baydarov<kbaidarov@dev.rtsoft.ru>
Index: linux_up/linux/arch/mips/au1000/common/irq.c
===================================================================
--- linux_up.orig/linux/arch/mips/au1000/common/irq.c
+++ linux_up/linux/arch/mips/au1000/common/irq.c
@@ -446,7 +446,6 @@ void __init arch_init_irq(void)
extern int au1xxx_ic0_nr_irqs;
cp0_status = read_c0_status();
- memset(irq_desc, 0, sizeof(irq_desc));
set_except_vector(0, au1000_IRQ);
/* Initialize interrupt controllers to a safe state.
next reply other threads:[~2005-09-22 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 11:32 kbaidarov [this message]
2005-09-30 22:19 ` [patch] db1550: useless memset() call Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43329632.8070400@dev.rtsoft.ru \
--to=kbaidarov@dev.rtsoft.ru \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox