From: Carlo Perassi <carlo@linux.it>
To: linux-mips@linux-mips.org
Subject: rfc about an uncommented string
Date: Sun, 9 Oct 2005 15:41:06 +0200 [thread overview]
Message-ID: <20051009134106.GB9091@voyager> (raw)
Hi.
As suggested (*) by Arthur Othieno on the kernel-janitors mailing list,
I bounce here this email for collecting comments.
The old email refers to 2.6.13-rc6 but the code is still the same on
2.6.14-rc3.
Thank you.
Hi.
I'd like to collect some comments about the following code
segment I found in
linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
(the "^^^" sequence is not mine, it's in the code)
#ifdef CONFIG_SERIO_I8042
/*
* According to the ITE Special BIOS Note for waking up the
* keyboard controller...
*/
static int init_8712_keyboard(void)
{
unsigned int cmd_port = 0x14000064;
unsigned int data_port = 0x14000060;
^^^^^^^^^^^
Somebody here doesn't grok the concept of io ports.
(*)
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004704.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004705.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-August/004707.html
http://lists.osdl.org/pipermail/kernel-janitors/2005-October/004955.html
--
Carlo Perassi - http://www.linux.it/~carlo/
next reply other threads:[~2005-10-09 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-09 13:41 Carlo Perassi [this message]
2005-10-10 11:11 ` rfc about an uncommented string Ralf Baechle
2005-10-10 11:23 ` Fuxin Zhang
2005-10-10 11:28 ` Geert Uytterhoeven
2005-10-10 11:43 ` Fuxin Zhang
2005-10-10 11:46 ` Geert Uytterhoeven
2005-10-10 13:18 ` Maciej W. Rozycki
2005-10-10 11:51 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051009134106.GB9091@voyager \
--to=carlo@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox