From: Fuxin Zhang <fxzhang@ict.ac.cn>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Carlo Perassi <carlo@linux.it>, linux-mips@linux-mips.org
Subject: Re: rfc about an uncommented string
Date: Mon, 10 Oct 2005 19:23:19 +0800 [thread overview]
Message-ID: <434A4F27.6010301@ict.ac.cn> (raw)
In-Reply-To: <20051010111149.GC2661@linux-mips.org>
We are using 8172 for 2.4 kernels presently,although may drop it
sometime later.
I don't read the 2.6 code,but it seems it remains the same as the copy
in 2.4(except that #ifdef changes).I can't see why the code is broken?
In case you mean the ioport address,mips_io_port_base for that board is
0xa0000000, inb(0x14000060) is reading from 0xb4000060, which is correct
for it.
Ralf Baechle wrote:
> On Sun, Oct 09, 2005 at 03:41:06PM +0200, Carlo Perassi wrote:
>
>
>>Hi.
>>As suggested (*) by Arthur Othieno on the kernel-janitors mailing list,
>>I bounce here this email for collecting comments.
>>The old email refers to 2.6.13-rc6 but the code is still the same on
>>2.6.14-rc3.
>>Thank you.
>>
>>Hi.
>>
>>I'd like to collect some comments about the following code
>>segment I found in
>>linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
>>(the "^^^" sequence is not mine, it's in the code)
>
>
> I know, I put it there. The code was obviously broken, so I place this
> hard to miss not right into the middle of it. It's there since ages and
> nobody did complain. So unless somebody complains - and that complaint
> better include some patches - I will delete support for the IT8172 and
> it's eval board.
>
> Ralf
>
>
>
next prev parent reply other threads:[~2005-10-10 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-09 13:41 rfc about an uncommented string Carlo Perassi
2005-10-10 11:11 ` Ralf Baechle
2005-10-10 11:23 ` Fuxin Zhang [this message]
2005-10-10 11:28 ` Geert Uytterhoeven
2005-10-10 11:43 ` Fuxin Zhang
2005-10-10 11:46 ` Geert Uytterhoeven
2005-10-10 13:18 ` Maciej W. Rozycki
2005-10-10 11:51 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434A4F27.6010301@ict.ac.cn \
--to=fxzhang@ict.ac.cn \
--cc=carlo@linux.it \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox