Re: [MIPS] Makefile crapectomy.

Re: [MIPS] Makefile crapectomy.

[Atsushi Nemoto]

On Mon, 20 Mar 2006 12:33:21 +0000, linux-mips@linux-mips.org wrote:
> Author: Ralf Baechle <ralf@linux-mips.org> Wed Mar 8 11:35:00 2006 +0000
> Commit: 434c1922d9865f1da02a2db604c1fdf8bee56b71
> Gitweb: http://www.linux-mips.org/g/linux/434c1922
> Branch: master
> 
> Dump all the ridiculously complicated stuff that was needed support
> compilers older and newer than 3.0.

This commit breaks sparse for 64bit kernel.  The -m64 option is
required.  Also, some macro values (such as _MIPS_TUNE, etc.)  contain
double-quote characters so it would be better quoting arguments by
single-quote characters.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 0d86f31..61359b7 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -616,7 +616,10 @@ LDFLAGS			+= -m $(ld-emul)
 ifdef CONFIG_MIPS
 CHECKFLAGS += $(shell $(CC) $(CFLAGS) -dM -E -xc /dev/null | \
 	egrep -vw '__GNUC_(MAJOR|MINOR|PATCHLEVEL)__' | \
-	sed -e 's/^\#define /-D/' -e 's/ /="/' -e 's/$$/"/')
+	sed -e 's/^\#define /-D/' -e "s/ /='/" -e "s/$$/'/")
+ifdef CONFIG_64BIT
+CHECKFLAGS		+= -m64
+endif
 endif
 
 OBJCOPYFLAGS		+= --remove-section=.reginfo

Re: [MIPS] Makefile crapectomy.

[Ralf Baechle]

On Sat, Apr 15, 2006 at 12:04:18AM +0900, Atsushi Nemoto wrote:

> This commit breaks sparse for 64bit kernel.  The -m64 option is
> required.  Also, some macro values (such as _MIPS_TUNE, etc.)  contain
> double-quote characters so it would be better quoting arguments by
> single-quote characters.

Thanks, applied.

  Ralf