From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: nigel@mips.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] fix cache coherency issues
Date: Thu, 24 Aug 2006 12:15:15 +0100 [thread overview]
Message-ID: <20060824111515.GA4490@linux-mips.org> (raw)
In-Reply-To: <20060824.101531.07643963.nemoto@toshiba-tops.co.jp>
On Thu, Aug 24, 2006 at 10:15:31AM +0900, Atsushi Nemoto wrote:
> On Wed, 23 Aug 2006 17:52:25 +0100, Nigel Stephens <nigel@mips.com> wrote:
> > Doesn't tlbidx need to be declared as a signed int, else the compiler
> > could optimize away this comparison.
>
> You are right. I'll fix it. Thanks.
Your patch also still contains copy_user_page(). The only user of it used
to be copy_user_highpage() so after our rewrite it can go away. I've
already applied both fixes to my working version of the patch.
Your patch only maps the source page. I'm trying to map the destination
page also and I'm hitting a few issues with it.
Ralf
next prev parent reply other threads:[~2006-08-24 11:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 16:15 [PATCH] fix cache coherency issues Atsushi Nemoto
2006-02-14 1:59 ` Yoichi Yuasa
2006-02-14 2:15 ` Atsushi Nemoto
2006-02-14 2:26 ` Yoichi Yuasa
2006-02-14 3:08 ` Atsushi Nemoto
2006-02-14 7:07 ` Yoichi Yuasa
2006-02-14 7:42 ` Atsushi Nemoto
2006-02-14 8:56 ` Yoichi Yuasa
2006-02-14 10:12 ` Atsushi Nemoto
2006-02-14 13:14 ` Atsushi Nemoto
2006-02-14 13:48 ` Kevin D. Kissell
2006-05-22 15:34 ` Atsushi Nemoto
2006-08-23 15:31 ` Atsushi Nemoto
2006-08-23 16:52 ` Nigel Stephens
2006-08-24 1:15 ` Atsushi Nemoto
2006-08-24 11:15 ` Ralf Baechle [this message]
2006-08-24 11:38 ` Atsushi Nemoto
2006-08-24 12:12 ` Ralf Baechle
2006-08-24 15:12 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824111515.GA4490@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=nigel@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox