[PATCH 9/12] removed unused resources for Cobalt

[PATCH 9/12] removed unused resources for Cobalt

[Yoichi Yuasa]

Hi Ralf,

This patch has removed unused resources for Cobalt.

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/gt64120/cobalt/setup.c mips/arch/mips/gt64120/cobalt/setup.c
--- mips-orig/arch/mips/gt64120/cobalt/setup.c	2006-08-21 23:02:23.229549750 +0900
+++ mips/arch/mips/gt64120/cobalt/setup.c	2006-08-21 23:00:31.314534000 +0900
@@ -49,42 +49,10 @@ void __init plat_timer_setup(struct irqa
 	setup_irq(COBALT_TIMER3_IRQ, irq);
 }
 
-static struct resource cobalt_io_resources[] = {
-	{
-		.start	= 0x00,
-		.end	= 0x1f,
-		.name	= "dma1",
-		.flags	= IORESOURCE_BUSY
-	}, {
-		.start	= 0x40,
-		.end	= 0x5f,
-		.name	= "timer",
-		.flags	= IORESOURCE_BUSY
-	}, {
-		.start	= 0x60,
-		.end	= 0x6f,
-		.name	= "keyboard",
-		.flags	= IORESOURCE_BUSY
-	}, {
-		.start	= 0x80,
-		.end	= 0x8f,
-		.name	= "dma page reg",
-		.flags	= IORESOURCE_BUSY
-	}, {
-		.start	= 0xc0,
-		.end	= 0xdf,
-		.name	= "dma2",
-		.flags	= IORESOURCE_BUSY
-	},
-};
-
-#define COBALT_IO_RESOURCES (sizeof(cobalt_io_resources)/sizeof(struct resource))
-
 void __init plat_mem_setup(void)
 {
 	static struct uart_port uart;
 	unsigned int devfn = PCI_DEVFN(COBALT_PCICONF_VIA, 0);
-	int i;
 
 	gt641xx_disable_alltimers();
 	board_time_init = gt641xx_timer3_init;
@@ -93,10 +61,6 @@ void __init plat_mem_setup(void)
 
 	ioport_resource.end = 0xffff;
 
-	/* request I/O space for devices used on all i[345]86 PCs */
-	for (i = 0; i < COBALT_IO_RESOURCES; i++)
-		request_resource(&ioport_resource, cobalt_io_resources + i);
-
         /* Read the cobalt id register out of the PCI config space */
         PCI_CFG_SET(devfn, (VIA_COBALT_BRD_ID_REG & ~0x3));
         cobalt_board_id = GT_READ(GT_PCI0_CFGDATA_OFS);

Re: [PATCH 9/12] removed unused resources for Cobalt

[Peter Horton]

On Tue, Aug 22, 2006 at 10:57:55PM +0900, Yoichi Yuasa wrote:
> 
> This patch has removed unused resources for Cobalt.
> 
> -static struct resource cobalt_io_resources[] = {
> -	{
> -		.start	= 0x00,
> -		.end	= 0x1f,
> -		.name	= "dma1",
> -		.flags	= IORESOURCE_BUSY
> -	}, {
> -		.start	= 0x40,
> -		.end	= 0x5f,
> -		.name	= "timer",
> -		.flags	= IORESOURCE_BUSY
> -	}, {
> -		.start	= 0x60,
> -		.end	= 0x6f,
> -		.name	= "keyboard",
> -		.flags	= IORESOURCE_BUSY
> -	}, {
> -		.start	= 0x80,
> -		.end	= 0x8f,
> -		.name	= "dma page reg",
> -		.flags	= IORESOURCE_BUSY
> -	}, {
> -		.start	= 0xc0,
> -		.end	= 0xdf,
> -		.name	= "dma2",
> -		.flags	= IORESOURCE_BUSY
> -	},
> -};
> -

Is this correct ? These resources maybe unused, but the registers are
there, and should be listed as unavailable.

P.

Re: [PATCH 9/12] removed unused resources for Cobalt

[Yoichi Yuasa]

Hi,

On Thu, 24 Aug 2006 20:31:21 +0100
pdh@colonel-panic.org (Peter Horton) wrote:

> On Tue, Aug 22, 2006 at 10:57:55PM +0900, Yoichi Yuasa wrote:
> > 
> > This patch has removed unused resources for Cobalt.
> > 
> > -static struct resource cobalt_io_resources[] = {
> > -	{
> > -		.start	= 0x00,
> > -		.end	= 0x1f,
> > -		.name	= "dma1",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x40,
> > -		.end	= 0x5f,
> > -		.name	= "timer",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x60,
> > -		.end	= 0x6f,
> > -		.name	= "keyboard",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x80,
> > -		.end	= 0x8f,
> > -		.name	= "dma page reg",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0xc0,
> > -		.end	= 0xdf,
> > -		.name	= "dma2",
> > -		.flags	= IORESOURCE_BUSY
> > -	},
> > -};
> > -
> 
> Is this correct ? These resources maybe unused, but the registers are
> there, and should be listed as unavailable.

How about the change of them to "reserved"?

Yoichi

Re: [PATCH 9/12] removed unused resources for Cobalt

[Yoichi Yuasa]

Hi,

On Thu, 24 Aug 2006 20:31:21 +0100
pdh@colonel-panic.org (Peter Horton) wrote:

> On Tue, Aug 22, 2006 at 10:57:55PM +0900, Yoichi Yuasa wrote:
> > 
> > This patch has removed unused resources for Cobalt.
> > 
> > -static struct resource cobalt_io_resources[] = {
> > -	{
> > -		.start	= 0x00,
> > -		.end	= 0x1f,
> > -		.name	= "dma1",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x40,
> > -		.end	= 0x5f,
> > -		.name	= "timer",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x60,
> > -		.end	= 0x6f,
> > -		.name	= "keyboard",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0x80,
> > -		.end	= 0x8f,
> > -		.name	= "dma page reg",
> > -		.flags	= IORESOURCE_BUSY
> > -	}, {
> > -		.start	= 0xc0,
> > -		.end	= 0xdf,
> > -		.name	= "dma2",
> > -		.flags	= IORESOURCE_BUSY
> > -	},
> > -};
> > -
> 
> Is this correct ? These resources maybe unused, but the registers are
> there, and should be listed as unavailable.

How about the change of them to "reserved"?

Yoichi

Re: [PATCH 9/12] removed unused resources for Cobalt

[Ralf Baechle]

On Fri, Aug 25, 2006 at 08:11:07AM +0900, Yoichi Yuasa wrote:

> > Is this correct ? These resources maybe unused, but the registers are
> > there, and should be listed as unavailable.
> 
> How about the change of them to "reserved"?

Afaik the SuperIO chip used in the Cobalt implements those registers but
due to missing external circuitry touching some of these registers is
dangerous.  Afaic that is the case for the PS/2 keyboard/mouse controller
ports.  So those should be marked as reserved.  The remaining registers
are implemented just not terribly useful, so I think what he have is
probably right as it is.

  Ralf

Re: [PATCH 9/12] removed unused resources for Cobalt

[Yoichi Yuasa]

On Fri, 25 Aug 2006 01:11:13 +0100
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Fri, Aug 25, 2006 at 08:11:07AM +0900, Yoichi Yuasa wrote:
> 
> > > Is this correct ? These resources maybe unused, but the registers are
> > > there, and should be listed as unavailable.
> > 
> > How about the change of them to "reserved"?
> 
> Afaik the SuperIO chip used in the Cobalt implements those registers but
> due to missing external circuitry touching some of these registers is
> dangerous.  Afaic that is the case for the PS/2 keyboard/mouse controller
> ports.  So those should be marked as reserved.  The remaining registers
> are implemented just not terribly useful, so I think what he have is
> probably right as it is.

OK, I'll update it.

Yoichi