Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] Do not use -msym32 option for modules.
@ 2006-10-10 13:13 Atsushi Nemoto
  2006-10-10 15:48 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2006-10-10 13:13 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

On 64-bit kernel, modules are loaded into XKSEG for now.  While XKSEG
address is not a sign-extended 32-bit address, we can not use -msym32
option.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 2124350..6691086 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -63,7 +63,9 @@ cflags-y		+= -mabi=64
 ifdef CONFIG_BUILD_ELF64
 cflags-y		+= $(call cc-option,-mno-explicit-relocs)
 else
-cflags-y		+= $(call cc-option,-msym32)
+# -msym32 can not be used for modules since they are loaded into XKSEG
+CFLAGS_MODULE		+= $(call cc-option,-mno-explicit-relocs)
+CFLAGS_KERNEL		+= $(call cc-option,-msym32)
 endif
 endif
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Do not use -msym32 option for modules.
  2006-10-10 13:13 [PATCH] Do not use -msym32 option for modules Atsushi Nemoto
@ 2006-10-10 15:48 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2006-10-10 15:48 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Tue, Oct 10, 2006 at 10:13:55PM +0900, Atsushi Nemoto wrote:

> On 64-bit kernel, modules are loaded into XKSEG for now.  While XKSEG
> address is not a sign-extended 32-bit address, we can not use -msym32
> option.

It would be a nice optimization to reserve XKSEG for modules on -msym32
configurations.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-10-10 15:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-10 13:13 [PATCH] Do not use -msym32 option for modules Atsushi Nemoto
2006-10-10 15:48 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox