From: Thiemo Seufer <ths@networkno.de>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
ralf@linux-mips.org, linux-mips@linux-mips.org,
fbuihuu@gmail.com
Subject: Re: [PATCH 1/5] Make __pa() uses CPHYSADDR() if really needed
Date: Thu, 12 Oct 2006 13:37:51 +0100 [thread overview]
Message-ID: <20061012123751.GA4044@networkno.de> (raw)
In-Reply-To: <452E2BB2.2090601@innova-card.com>
Franck Bui-Huu wrote:
> Atsushi Nemoto wrote:
> > On Wed, 11 Oct 2006 18:01:43 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> >>> __pa() is used in many place indirectly via virt_to_page().
> >> what about make virt_to_page() use virt_to_phys() instead ?
> >
> > No objection for virt_to_phys(), but I found other __pa() usages in
> > kernel.
> >
> > drivers/char/mem.c: && addr >= __pa(high_memory);
> > drivers/char/mem.c: return addr >= __pa(high_memory);
> > drivers/char/mem.c: if (addr + count > __pa(high_memory))
> > drivers/char/mem.c: pfn = __pa((u64)vma->vm_pgoff << PAGE_SHIFT) >> PAGE_SHIFT;
> >
> > So __pa() should handle >512MB address unless we change all __pa() usages.
>
> weird, I really thought that __pa() shouldn't be used by drivers...
> Let see what people on lkml think about this usage, you'll be CC'ed
> if you want to.
I guess /dev/mem is allowed to as an exception.
Thiemo
next prev parent reply other threads:[~2006-10-12 12:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 12:08 [PATCH 0/5] Get ride of CPHYSADDR() in setup.c Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 1/5] Make __pa() uses CPHYSADDR() if really needed Franck Bui-Huu
2006-10-11 13:33 ` Atsushi Nemoto
2006-10-11 14:15 ` Franck Bui-Huu
2006-10-11 15:30 ` Atsushi Nemoto
2006-10-11 16:01 ` Franck Bui-Huu
2006-10-11 17:07 ` Franck Bui-Huu
2006-10-12 10:05 ` Atsushi Nemoto
2006-10-12 11:49 ` Franck Bui-Huu
2006-10-12 12:37 ` Thiemo Seufer [this message]
2006-10-11 12:08 ` [PATCH 2/5] setup.c: get ride of CPHYSADDR() Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 3/5] setup.c: clean up initrd related code Franck Bui-Huu
2006-10-13 8:23 ` Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 4/5] Introduce __pa_symbol() Franck Bui-Huu
2006-10-11 15:34 ` Atsushi Nemoto
2006-10-11 16:13 ` Franck Bui-Huu
2006-10-12 9:48 ` Atsushi Nemoto
2006-10-12 11:57 ` Franck Bui-Huu
2006-10-12 14:27 ` Atsushi Nemoto
2006-10-11 12:08 ` [PATCH 5/5] setup.c: use __pa_symbol() where needed Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012123751.GA4044@networkno.de \
--to=ths@networkno.de \
--cc=anemo@mba.ocn.ne.jp \
--cc=fbuihuu@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox