From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: vagabon.xyz@gmail.com, ralf@linux-mips.org, ths@networkno.de,
linux-mips@linux-mips.org
Subject: Re: [PATCH 4/5] Introduce __pa_symbol()
Date: Wed, 11 Oct 2006 18:13:01 +0200 [thread overview]
Message-ID: <452D180D.9020700@innova-card.com> (raw)
In-Reply-To: <20061012.003436.130240259.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Wed, 11 Oct 2006 14:08:44 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
>> This patch introduces __pa_symbol() macro which should be used to
>> calculate the physical address of kernel symbols. It also relies
>> on RELOC_HIDE() to avoid any compiler's oddities when doing
>> arithmetics on symbols.
>
> I agree with you that we need __pa_symbol(), but what is a purpose of
> using RELOC_HIDE() here? Frankly I do not understand what
> RELOC_HIDE() does...
>
RELOC_HIDE(x) is used because arithmetic on symbol addresses is
undefined in C language. It avoid gcc to know that:
RELOC_HIDE(&_end) + OFFSET
is an operation on a symbol address and thus avoid an undefined
operation.
Franck
next prev parent reply other threads:[~2006-10-11 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 12:08 [PATCH 0/5] Get ride of CPHYSADDR() in setup.c Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 1/5] Make __pa() uses CPHYSADDR() if really needed Franck Bui-Huu
2006-10-11 13:33 ` Atsushi Nemoto
2006-10-11 14:15 ` Franck Bui-Huu
2006-10-11 15:30 ` Atsushi Nemoto
2006-10-11 16:01 ` Franck Bui-Huu
2006-10-11 17:07 ` Franck Bui-Huu
2006-10-12 10:05 ` Atsushi Nemoto
2006-10-12 11:49 ` Franck Bui-Huu
2006-10-12 12:37 ` Thiemo Seufer
2006-10-11 12:08 ` [PATCH 2/5] setup.c: get ride of CPHYSADDR() Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 3/5] setup.c: clean up initrd related code Franck Bui-Huu
2006-10-13 8:23 ` Franck Bui-Huu
2006-10-11 12:08 ` [PATCH 4/5] Introduce __pa_symbol() Franck Bui-Huu
2006-10-11 15:34 ` Atsushi Nemoto
2006-10-11 16:13 ` Franck Bui-Huu [this message]
2006-10-12 9:48 ` Atsushi Nemoto
2006-10-12 11:57 ` Franck Bui-Huu
2006-10-12 14:27 ` Atsushi Nemoto
2006-10-11 12:08 ` [PATCH 5/5] setup.c: use __pa_symbol() where needed Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452D180D.9020700@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox