From: Ralf Baechle <ralf@linux-mips.org>
To: Antonio SJ Musumeci <bile@landofbile.com>
Cc: linux-mips@linux-mips.org
Subject: Re: patch: include/asm-mips/system.h __cmpxchg64 bugfix and cleanup
Date: Sun, 15 Oct 2006 19:42:26 +0100 [thread overview]
Message-ID: <20061015184226.GA3259@linux-mips.org> (raw)
In-Reply-To: <20061013151841.3a902627@amiga>
On Fri, Oct 13, 2006 at 03:18:41PM -0400, Antonio SJ Musumeci wrote:
> Wouldn't it be better to check the macro in the preprocessor instead of
> runtime? And why are those defined to 0 instead of explicitly undef'ed?
> I've found one bug because it was assumed to be undefined instead of 0.
> If no one objects I'll post a patch undefing those and fix any bugs I've
> found because of them.
Any reasonable system configuration will define cpu_has_llsc to 1 in
order to override the default. R10000_LLSC_WAR is a constant as well.
So only one of the three if blocks will remain. If that's not the case
you either don't have a cpu-feature-overrides.h file for your platform
or it doesn't define cpu_has_llsc to a constant expression.
Ralf
next prev parent reply other threads:[~2006-10-15 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 18:03 patch: include/asm-mips/system.h __cmpxchg64 bugfix and cleanup bile
2006-10-13 10:42 ` Ralf Baechle
2006-10-13 13:53 ` Antonio SJ Musumeci
2006-10-13 14:11 ` Ralf Baechle
2006-10-13 19:18 ` Antonio SJ Musumeci
2006-10-15 18:42 ` Ralf Baechle [this message]
2006-10-18 18:08 ` Antonio SJ Musumeci
2006-10-18 18:41 ` Thiemo Seufer
2006-10-18 19:45 ` Antonio SJ Musumeci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061015184226.GA3259@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=bile@landofbile.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox