[PATCH] Clean up serial console support on Sibyte 1250 duart

[PATCH] Clean up serial console support on Sibyte 1250 duart

[Andrew Sharp]

[-- Attachment #1: Type: text/plain, Size: 74 bytes --]

Clean up the serial console support on the Sibyte 1250's built in duart.

Re: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Ralf Baechle]

On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:

Patch looks reasonable at a quick glance.  I'll review it for real
later, just wanted to mention that the drivers/char/ Sibyte serial
driver is really a dead end of the evolution.  The driver should
be replaced with a new driver based on the the new drivers/serial/
infrastructure.

  Ralf

Re: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Woodrow Tree]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On 2/19/07, Ralf Baechle <ralf@linux-mips.org> wrote:
>
> On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:
>
> Patch looks reasonable at a quick glance.  I'll review it for real
> later, just wanted to mention that the drivers/char/ Sibyte serial
> driver is really a dead end of the evolution.  The driver should
> be replaced with a new driver based on the the new drivers/serial/
> infrastructure.
>
>   Ralf
>


That explains the "shouldn't there be a general frame work for all this?"
itch in the back of my neck the whole time I was hacking on it.

a

[-- Attachment #2: Type: text/html, Size: 916 bytes --]

Re: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Ralf Baechle]

On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:

> Clean up the serial console support on the Sibyte 1250's built in duart.

Thanks, applied with some additional formatting fixes.

  Ralf

RE: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Kaz Kylheku]

Andrew Sharp wrote:
> Clean up the serial console support on the Sibyte 1250's
> built in duart.

Hi Andrew,

Would it be too much trouble to split the patch into two: the whitespace
changes, and the actual bugfix?

RE: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Kaz Kylheku]

Andrew Sharp wrote:
> Clean up the serial console support on the Sibyte 1250's
> built in duart.

Hi Andrew,

Would it be too much trouble to split the patch into two: the whitespace
changes, and the actual bugfix?

Re: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Ralf Baechle]

On Tue, Feb 20, 2007 at 09:03:56AM -0800, Kaz Kylheku wrote:

> Andrew Sharp wrote:
> > Clean up the serial console support on the Sibyte 1250's
> > built in duart.
> 
> Hi Andrew,
> 
> Would it be too much trouble to split the patch into two: the whitespace
> changes, and the actual bugfix?

While that's strongly prefered I wasn't picky in this case because this
driver only has a single job left to do - as a stop gap until there is
a new driver for the drivers/serial subsystem.

  Ralf

Re: [PATCH] Clean up serial console support on Sibyte 1250 duart

[Maciej W. Rozycki]

On Tue, 20 Feb 2007, Ralf Baechle wrote:

> While that's strongly prefered I wasn't picky in this case because this
> driver only has a single job left to do - as a stop gap until there is
> a new driver for the drivers/serial subsystem.

 Which will be a funny exercise because of that AC97 codec hanging off one 
of the lines.  I guess it gives me enough incentive to put it on my to-do 
list for not such a distant future. ;-)

 It's a pity they did not wire the clock lines (TxC, RxC) to the serial 
port connectors (I guess PCB space was more important) -- it would have 
given me yet more incentive...

  Maciej