From: Ladislav Michl <ladis@linux-mips.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Marc St-Jean <stjeanma@pmc-sierra.com>,
akpm@linux-foundation.org, linux-mips@linux-mips.org,
i2c@lm-sensors.org
Subject: Re: [PATCH 8/12] drivers: PMC MSP71xx TWI driver]
Date: Mon, 19 Mar 2007 11:41:55 +0100 [thread overview]
Message-ID: <20070319104155.GA16362@michl.2n.cz> (raw)
In-Reply-To: <20070317085244.f99aad86.khali@linux-fr.org>
On Sat, Mar 17, 2007 at 08:52:44AM +0100, Jean Delvare wrote:
[snip]
> Why are you making a separate algorithm driver? This should really only
> be done when the algorithm is very generic. This is the exception, not
> the rule. These days I tend to move algorithm code back into the only
> bus driver that uses them (i2c-algo-sibyte done recently, i2c-algo-sgi
> is next on my list.)
Please remove i2c-algo-sgi from your list. This algorithm is used by
the VINO asic (drivers/media/video/vino.c) present in SGI Indy machines as
well as by the MACE asic (no driver exist yet) present in SGI O2 machines.
You may consider applying this patch (also removes trailing whitespace).
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
--- linux-omap-2.6.git/drivers/i2c/algos/i2c-algo-sgi.c.orig 2007-03-19 11:26:30.000000000 +0100
+++ linux-omap-2.6.git/drivers/i2c/algos/i2c-algo-sgi.c 2007-03-19 11:39:00.000000000 +0100
@@ -1,6 +1,7 @@
/*
- * i2c-algo-sgi.c: i2c driver algorithms for SGI adapters.
- *
+ * i2c-algo-sgi.c: i2c driver algorithm used by the VINO (SGI Indy) and
+ * MACE (SGI O2) chips.
+ *
* This file is subject to the terms and conditions of the GNU General Public
* License version 2 as published by the Free Software Foundation.
*
@@ -162,8 +163,8 @@
.functionality = sgi_func,
};
-/*
- * registering functions to load algorithms at runtime
+/*
+ * registering functions to load algorithms at runtime
*/
int i2c_sgi_add_bus(struct i2c_adapter *adap)
{
next prev parent reply other threads:[~2007-03-19 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 23:03 [PATCH 8/12] drivers: PMC MSP71xx TWI driver] Ralf Baechle
2007-03-17 7:52 ` Jean Delvare
2007-03-19 10:41 ` Ladislav Michl [this message]
2007-03-19 13:36 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2007-03-21 0:42 Marc St-Jean
2007-03-21 15:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070319104155.GA16362@michl.2n.cz \
--to=ladis@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stjeanma@pmc-sierra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox