[PATCH] Make MIPS udelay() preempt safe

[PATCH] Make MIPS udelay() preempt safe

[Deepak Saxena]

Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT

Signed-off-by: Manish Lachwani <mlachwani@mvista.com>
Signed-off-by: Deepak Saxena <dsaxena@mvista.com>

---

This needs to go into -rt patch set or directly into the MIPS tree.
Applies cleanly to 2.6.21-rc4 and 2.6.21-rc3-rt0.

 include/asm-mips/delay.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18/include/asm-mips/delay.h
===================================================================
--- linux-2.6.18.orig/include/asm-mips/delay.h
+++ linux-2.6.18/include/asm-mips/delay.h
@@ -79,7 +79,7 @@ static inline void __udelay(unsigned lon
 	__delay(usecs);
 }
 
-#define __udelay_val cpu_data[smp_processor_id()].udelay_val
+#define __udelay_val cpu_data[raw_smp_processor_id()].udelay_val
 
 #define udelay(usecs) __udelay((usecs),__udelay_val)
 

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertolt Brecht

Re: [PATCH] Make MIPS udelay() preempt safe

[Deepak Saxena]

Nevermind on this one. I just noticed that the original patch is not
needed.

~Deepak

On Mar 19 2007, at 16:49, Deepak Saxena was caught saying:
> Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT
> 
> Signed-off-by: Manish Lachwani <mlachwani@mvista.com>
> Signed-off-by: Deepak Saxena <dsaxena@mvista.com>
> 
> ---
> 
> This needs to go into -rt patch set or directly into the MIPS tree.
> Applies cleanly to 2.6.21-rc4 and 2.6.21-rc3-rt0.
> 
>  include/asm-mips/delay.h |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.18/include/asm-mips/delay.h
> ===================================================================
> --- linux-2.6.18.orig/include/asm-mips/delay.h
> +++ linux-2.6.18/include/asm-mips/delay.h
> @@ -79,7 +79,7 @@ static inline void __udelay(unsigned lon
>  	__delay(usecs);
>  }
>  
> -#define __udelay_val cpu_data[smp_processor_id()].udelay_val
> +#define __udelay_val cpu_data[raw_smp_processor_id()].udelay_val
>  
>  #define udelay(usecs) __udelay((usecs),__udelay_val)
>  
> 
> -- 
> Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net
> 
> In the end, they will not say, "those were dark times,"  they will ask
> "why were their poets silent?" - Bertolt Brecht

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertolt Brecht

Re: [PATCH] Make MIPS udelay() preempt safe

[Atsushi Nemoto]

On Mon, 19 Mar 2007 17:03:00 -0700, Deepak Saxena <dsaxena@plexity.net> wrote:
> Nevermind on this one. I just noticed that the original patch is not
> needed.

Why?  I think the patch is needed to silence error message with
CONFIG_DEBUG_PREEMPT.

---
Atsushi Nemoto

Re: [PATCH] Make MIPS udelay() preempt safe

[Ralf Baechle]

On Mon, Mar 19, 2007 at 04:49:45PM -0700, Deepak Saxena wrote:

> Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT

I don't understand why you're withdrawing this patch - it makes perfect
sense as Atsushi has also already found, so I'm going to apply it.

  Ralf