Re: [MIPS] Implement flush_anon_page().

Re: [MIPS] Implement flush_anon_page().

[Atsushi Nemoto]

Move an external declaration of __flush_anon_page() to toplevel to
avoid this sparse warning:

linux/arch/mips/mm/cache.c:92:6: warning: symbol '__flush_anon_page' was not declared. Should it be static?

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/include/asm-mips/cacheflush.h b/include/asm-mips/cacheflush.h
index 78a624d..28d907d 100644
--- a/include/asm-mips/cacheflush.h
+++ b/include/asm-mips/cacheflush.h
@@ -49,11 +49,10 @@ static inline void flush_dcache_page(str
 #define flush_dcache_mmap_unlock(mapping)	do { } while (0)
 
 #define ARCH_HAS_FLUSH_ANON_PAGE
+extern void __flush_anon_page(struct page *, unsigned long);
 static inline void flush_anon_page(struct vm_area_struct *vma,
 	struct page *page, unsigned long vmaddr)
 {
-	extern void __flush_anon_page(struct page *, unsigned long);
-
 	if (cpu_has_dc_aliases && PageAnon(page))
 		__flush_anon_page(page, vmaddr);
 }

Re: [MIPS] Implement flush_anon_page().

[Ralf Baechle]

On Sun, Mar 25, 2007 at 12:14:33AM +0900, Atsushi Nemoto wrote:

> Move an external declaration of __flush_anon_page() to toplevel to
> avoid this sparse warning:
> 
> linux/arch/mips/mm/cache.c:92:6: warning: symbol '__flush_anon_page' was not declared. Should it be static?

Sometimes sparse is a PITA ...   Applied.

Thanks,

  Ralf

Re: [MIPS] Implement flush_anon_page().

[Atsushi Nemoto]

On Sat, 24 Mar 2007 16:27:21 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> Sometimes sparse is a PITA ...   Applied.

Thanks.  And one more.  Fix kunmap_coherent() usage.  Or is it a time
to kill the unused argument of kunmap_coherent()?

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c
index 4e8f1b6..70ccc5d 100644
--- a/arch/mips/mm/cache.c
+++ b/arch/mips/mm/cache.c
@@ -96,7 +96,7 @@ void __flush_anon_page(struct page *page
 
 		kaddr = kmap_coherent(page, vmaddr);
 		flush_data_cache_page((unsigned long)kaddr);
-		kunmap_coherent(kaddr);
+		kunmap_coherent(page);
 	}
 }
 

Re: [MIPS] Implement flush_anon_page().

[Ralf Baechle]

On Sun, Mar 25, 2007 at 02:10:10AM +0900, Atsushi Nemoto wrote:

> Thanks.  And one more.  Fix kunmap_coherent() usage.  Or is it a time
> to kill the unused argument of kunmap_coherent()?

Yes, it probably is.  But that sort of cleanup is 2.6.22 stuff.

  Ralf