* [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
@ 2007-05-10 16:02 Atsushi Nemoto
2007-05-11 10:49 ` Ralf Baechle
2007-05-11 12:14 ` Franck Bui-Huu
0 siblings, 2 replies; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-10 16:02 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, sam
On 64-bit MIPS, only N64 ABI is checked by default. This patch adds
some rules for other ABIs. This results in these warnings at the
moment:
CALL-N32 /home/git/linux-mips/scripts/checksyscalls.sh
<stdin>:148:2: warning: #warning syscall time not implemented
<stdin>:424:2: warning: #warning syscall select not implemented
<stdin>:440:2: warning: #warning syscall uselib not implemented
<stdin>:856:2: warning: #warning syscall vfork not implemented
<stdin>:868:2: warning: #warning syscall truncate64 not implemented
<stdin>:872:2: warning: #warning syscall ftruncate64 not implemented
<stdin>:876:2: warning: #warning syscall stat64 not implemented
<stdin>:880:2: warning: #warning syscall lstat64 not implemented
<stdin>:884:2: warning: #warning syscall fstat64 not implemented
<stdin>:980:2: warning: #warning syscall getdents64 not implemented
<stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
<stdin>:1284:2: warning: #warning syscall fstatat64 not implemented
<stdin>:1364:2: warning: #warning syscall utimensat not implemented
CALL-O32 /home/git/linux-mips/scripts/checksyscalls.sh
<stdin>:424:2: warning: #warning syscall select not implemented
<stdin>:856:2: warning: #warning syscall vfork not implemented
<stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
<stdin>:1364:2: warning: #warning syscall utimensat not implemented
CALL /home/git/linux-mips/scripts/checksyscalls.sh
<stdin>:148:2: warning: #warning syscall time not implemented
<stdin>:424:2: warning: #warning syscall select not implemented
<stdin>:440:2: warning: #warning syscall uselib not implemented
<stdin>:856:2: warning: #warning syscall vfork not implemented
<stdin>:980:2: warning: #warning syscall getdents64 not implemented
<stdin>:1364:2: warning: #warning syscall utimensat not implemented
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index a68d462..f450066 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -709,3 +709,25 @@ archclean:
CLEAN_FILES += vmlinux.32 \
vmlinux.64 \
vmlinux.ecoff
+
+quiet_cmd_syscalls_n32 = CALL-N32 $<
+ cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
+
+quiet_cmd_syscalls_o32 = CALL-O32 $<
+ cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
+
+PHONY += missing-syscalls-n32 missing-syscalls-o32
+
+missing-syscalls-n32: scripts/checksyscalls.sh FORCE
+ $(call cmd,syscalls_n32)
+
+missing-syscalls-o32: scripts/checksyscalls.sh FORCE
+ $(call cmd,syscalls_o32)
+
+archprepare:
+ifdef CONFIG_MIPS32_N32
+ $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
+endif
+ifdef CONFIG_MIPS32_O32
+ $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
+endif
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-10 16:02 [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI Atsushi Nemoto
@ 2007-05-11 10:49 ` Ralf Baechle
2007-05-11 12:14 ` Franck Bui-Huu
1 sibling, 0 replies; 20+ messages in thread
From: Ralf Baechle @ 2007-05-11 10:49 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, sam
On Fri, May 11, 2007 at 01:02:34AM +0900, Atsushi Nemoto wrote:
> On 64-bit MIPS, only N64 ABI is checked by default. This patch adds
> some rules for other ABIs. This results in these warnings at the
> moment:
These warnings are definately valuable so I applied your patch. Some of
the warnings are a little useless though, for example the ones about the
uselib syscall.
Ralf
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-10 16:02 [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI Atsushi Nemoto
2007-05-11 10:49 ` Ralf Baechle
@ 2007-05-11 12:14 ` Franck Bui-Huu
2007-05-11 13:51 ` Thiemo Seufer
2007-05-11 15:59 ` Atsushi Nemoto
1 sibling, 2 replies; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-11 12:14 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
Hi Atsushi,
On 5/10/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On 64-bit MIPS, only N64 ABI is checked by default. This patch adds
> some rules for other ABIs. This results in these warnings at the
> moment:
>
nice to see this second version which is nicer IMHO.
> CALL-N32 /home/git/linux-mips/scripts/checksyscalls.sh
> <stdin>:148:2: warning: #warning syscall time not implemented
> <stdin>:424:2: warning: #warning syscall select not implemented
> <stdin>:440:2: warning: #warning syscall uselib not implemented
> <stdin>:856:2: warning: #warning syscall vfork not implemented
> <stdin>:868:2: warning: #warning syscall truncate64 not implemented
> <stdin>:872:2: warning: #warning syscall ftruncate64 not implemented
> <stdin>:876:2: warning: #warning syscall stat64 not implemented
> <stdin>:880:2: warning: #warning syscall lstat64 not implemented
> <stdin>:884:2: warning: #warning syscall fstat64 not implemented
> <stdin>:980:2: warning: #warning syscall getdents64 not implemented
> <stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
> <stdin>:1284:2: warning: #warning syscall fstatat64 not implemented
> <stdin>:1364:2: warning: #warning syscall utimensat not implemented
> CALL-O32 /home/git/linux-mips/scripts/checksyscalls.sh
> <stdin>:424:2: warning: #warning syscall select not implemented
> <stdin>:856:2: warning: #warning syscall vfork not implemented
> <stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
> <stdin>:1364:2: warning: #warning syscall utimensat not implemented
> CALL /home/git/linux-mips/scripts/checksyscalls.sh
> <stdin>:148:2: warning: #warning syscall time not implemented
> <stdin>:424:2: warning: #warning syscall select not implemented
> <stdin>:440:2: warning: #warning syscall uselib not implemented
> <stdin>:856:2: warning: #warning syscall vfork not implemented
> <stdin>:980:2: warning: #warning syscall getdents64 not implemented
> <stdin>:1364:2: warning: #warning syscall utimensat not implemented
>
woah, quite a lot of works are waiting for you ;)
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index a68d462..f450066 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -709,3 +709,25 @@ archclean:
> CLEAN_FILES += vmlinux.32 \
> vmlinux.64 \
> vmlinux.ecoff
> +
> +quiet_cmd_syscalls_n32 = CALL-N32 $<
> + cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
> +
> +quiet_cmd_syscalls_o32 = CALL-O32 $<
> + cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
> +
> +PHONY += missing-syscalls-n32 missing-syscalls-o32
> +
> +missing-syscalls-n32: scripts/checksyscalls.sh FORCE
> + $(call cmd,syscalls_n32)
> +
> +missing-syscalls-o32: scripts/checksyscalls.sh FORCE
> + $(call cmd,syscalls_o32)
> +
> +archprepare:
I didn't know about that rule. However I'm not sure it's a good idea
to add a set of commands
to it since it's multiple rule...
> +ifdef CONFIG_MIPS32_N32
> + $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
or can't we do instead:
$(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
and get rid of "missing-syscalls-n32" rule. Thus this avoids to
duplicate "missing-syscalls" command.
> +endif
> +ifdef CONFIG_MIPS32_O32
> + $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
ditto:
$(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
> +endif
>
>
I'm wondering if this should stay at the end where cleaning rules live...
Anyways thanks.
--
Franck
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-11 12:14 ` Franck Bui-Huu
@ 2007-05-11 13:51 ` Thiemo Seufer
2007-05-11 14:41 ` Atsushi Nemoto
2007-05-11 15:59 ` Atsushi Nemoto
1 sibling, 1 reply; 20+ messages in thread
From: Thiemo Seufer @ 2007-05-11 13:51 UTC (permalink / raw)
To: Franck Bui-Huu; +Cc: Atsushi Nemoto, linux-mips, ralf, sam
Franck Bui-Huu wrote:
> Hi Atsushi,
>
> On 5/10/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> >On 64-bit MIPS, only N64 ABI is checked by default. This patch adds
> >some rules for other ABIs. This results in these warnings at the
> >moment:
> >
>
> nice to see this second version which is nicer IMHO.
>
> > CALL-N32 /home/git/linux-mips/scripts/checksyscalls.sh
> ><stdin>:148:2: warning: #warning syscall time not implemented
> ><stdin>:424:2: warning: #warning syscall select not implemented
> ><stdin>:440:2: warning: #warning syscall uselib not implemented
> ><stdin>:856:2: warning: #warning syscall vfork not implemented
> ><stdin>:868:2: warning: #warning syscall truncate64 not implemented
> ><stdin>:872:2: warning: #warning syscall ftruncate64 not implemented
> ><stdin>:876:2: warning: #warning syscall stat64 not implemented
> ><stdin>:880:2: warning: #warning syscall lstat64 not implemented
> ><stdin>:884:2: warning: #warning syscall fstat64 not implemented
> ><stdin>:980:2: warning: #warning syscall getdents64 not implemented
> ><stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
> ><stdin>:1284:2: warning: #warning syscall fstatat64 not implemented
> ><stdin>:1364:2: warning: #warning syscall utimensat not implemented
> > CALL-O32 /home/git/linux-mips/scripts/checksyscalls.sh
> ><stdin>:424:2: warning: #warning syscall select not implemented
> ><stdin>:856:2: warning: #warning syscall vfork not implemented
> ><stdin>:1176:2: warning: #warning syscall fadvise64_64 not implemented
> ><stdin>:1364:2: warning: #warning syscall utimensat not implemented
> > CALL /home/git/linux-mips/scripts/checksyscalls.sh
> ><stdin>:148:2: warning: #warning syscall time not implemented
> ><stdin>:424:2: warning: #warning syscall select not implemented
> ><stdin>:440:2: warning: #warning syscall uselib not implemented
> ><stdin>:856:2: warning: #warning syscall vfork not implemented
> ><stdin>:980:2: warning: #warning syscall getdents64 not implemented
> ><stdin>:1364:2: warning: #warning syscall utimensat not implemented
> >
>
> woah, quite a lot of works are waiting for you ;)
AFAICS everything except utimensat is a false positive.
Thiemo
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-11 13:51 ` Thiemo Seufer
@ 2007-05-11 14:41 ` Atsushi Nemoto
0 siblings, 0 replies; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-11 14:41 UTC (permalink / raw)
To: ths; +Cc: vagabon.xyz, linux-mips, ralf, sam
On Fri, 11 May 2007 14:51:14 +0100, Thiemo Seufer <ths@networkno.de> wrote:
> > woah, quite a lot of works are waiting for you ;)
>
> AFAICS everything except utimensat is a false positive.
Well, fadvise64_64 is not a false positive, isn't it? LFS version of
posix_fadvise needs fadvise64_64, not fadvise64.
And anyway fadvise64_64 needs some fix to adjust longlong argument as
I said before.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-11 12:14 ` Franck Bui-Huu
2007-05-11 13:51 ` Thiemo Seufer
@ 2007-05-11 15:59 ` Atsushi Nemoto
2007-05-11 19:23 ` Franck Bui-Huu
1 sibling, 1 reply; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-11 15:59 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Fri, 11 May 2007 14:14:47 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> or can't we do instead:
>
> $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
>
> and get rid of "missing-syscalls-n32" rule. Thus this avoids to
> duplicate "missing-syscalls" command.
Thank you for suggestion. How about this?
Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
Use standard missing-syscalls with EXTRA_CFLAGS instead of duplicating
the command. Suggested by Franck Bui-Huu. Also add "echo" to show
the target ABI.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index f450066..25c7318 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -710,24 +710,12 @@ CLEAN_FILES += vmlinux.32 \
vmlinux.64 \
vmlinux.ecoff
-quiet_cmd_syscalls_n32 = CALL-N32 $<
- cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
-
-quiet_cmd_syscalls_o32 = CALL-O32 $<
- cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
-
-PHONY += missing-syscalls-n32 missing-syscalls-o32
-
-missing-syscalls-n32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_n32)
-
-missing-syscalls-o32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_o32)
-
archprepare:
ifdef CONFIG_MIPS32_N32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
+ @echo ' Checking missing-syscalls for N32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
endif
ifdef CONFIG_MIPS32_O32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
+ @echo ' Checking missing-syscalls for O32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
endif
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-11 15:59 ` Atsushi Nemoto
@ 2007-05-11 19:23 ` Franck Bui-Huu
2007-05-12 16:47 ` Atsushi Nemoto
0 siblings, 1 reply; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-11 19:23 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
On 5/11/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> archprepare:
> ifdef CONFIG_MIPS32_N32
> - $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
> + @echo ' Checking missing-syscalls for N32'
> + $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
> endif
> ifdef CONFIG_MIPS32_O32
> - $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
> + @echo ' Checking missing-syscalls for O32'
> + $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
> endif
>
Well I'm not sure how revelant are the echos...
But I still think that (a) you shouldn't put any command in
'archprepare' multiple rule (b) you should move this rule from the
cleaning targets.
Thanks
--
Franck
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-11 19:23 ` Franck Bui-Huu
@ 2007-05-12 16:47 ` Atsushi Nemoto
2007-05-12 18:58 ` Sam Ravnborg
` (2 more replies)
0 siblings, 3 replies; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-12 16:47 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Fri, 11 May 2007 21:23:55 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> Well I'm not sure how revelant are the echos...
Without the echos, you can get something like this and it seems unlear
which ABI should be fixed.
CALL /home/git/linux-mips/scripts/checksyscalls.sh
...
CALL /home/git/linux-mips/scripts/checksyscalls.sh
...
CALL /home/git/linux-mips/scripts/checksyscalls.sh
...
> But I still think that (a) you shouldn't put any command in
> 'archprepare' multiple rule (b) you should move this rule from the
> cleaning targets.
Oh, I missed those points. Revised again.
Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
Use standard missing-syscalls with EXTRA_CFLAGS instead of duplicating
the command. Suggested by Franck Bui-Huu. Also add "echo" to show
the target ABI.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index f450066..5aa0f41 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -702,6 +702,19 @@ vmlinux.srec: $(vmlinux-32)
CLEAN_FILES += vmlinux.ecoff \
vmlinux.srec
+PHONY += arch-missing-syscalls
+arch-missing-syscalls: prepare1
+ifdef CONFIG_MIPS32_N32
+ @echo ' Checking missing-syscalls for N32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
+endif
+ifdef CONFIG_MIPS32_O32
+ @echo ' Checking missing-syscalls for O32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
+endif
+
+archprepare: arch-missing-syscalls
+
archclean:
@$(MAKE) $(clean)=arch/mips/boot
@$(MAKE) $(clean)=arch/mips/lasat
@@ -709,25 +722,3 @@ archclean:
CLEAN_FILES += vmlinux.32 \
vmlinux.64 \
vmlinux.ecoff
-
-quiet_cmd_syscalls_n32 = CALL-N32 $<
- cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
-
-quiet_cmd_syscalls_o32 = CALL-O32 $<
- cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
-
-PHONY += missing-syscalls-n32 missing-syscalls-o32
-
-missing-syscalls-n32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_n32)
-
-missing-syscalls-o32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_o32)
-
-archprepare:
-ifdef CONFIG_MIPS32_N32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
-endif
-ifdef CONFIG_MIPS32_O32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
-endif
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-12 16:47 ` Atsushi Nemoto
@ 2007-05-12 18:58 ` Sam Ravnborg
2007-05-13 13:51 ` Atsushi Nemoto
2007-05-14 7:27 ` Franck Bui-Huu
2007-05-14 7:23 ` Franck Bui-Huu
2007-05-29 15:38 ` Atsushi Nemoto
2 siblings, 2 replies; 20+ messages in thread
From: Sam Ravnborg @ 2007-05-12 18:58 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: vagabon.xyz, linux-mips, ralf
On Sun, May 13, 2007 at 01:47:13AM +0900, Atsushi Nemoto wrote:
> On Fri, 11 May 2007 21:23:55 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> > Well I'm not sure how revelant are the echos...
>
> Without the echos, you can get something like this and it seems unlear
> which ABI should be fixed.
>
> CALL /home/git/linux-mips/scripts/checksyscalls.sh
> ...
> CALL /home/git/linux-mips/scripts/checksyscalls.sh
> ...
> CALL /home/git/linux-mips/scripts/checksyscalls.sh
> ...
>
> > But I still think that (a) you shouldn't put any command in
> > 'archprepare' multiple rule (b) you should move this rule from the
> > cleaning targets.
>
> Oh, I missed those points. Revised again.
>
>
> Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
This is overengineered. The only reason to make the syscall check
for each and every build was that this was easy and the missing syscalls
are easy to spot during a normal build.
But checking all combinations is just not worth it.
The arch responsible are assumed to build for the different architectures
once in a while so a missing syscall are likely to be detected anyway.
We cannot run each and every consistency check in all combinations
for each build - that would end in only build noise.
Sam
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-12 18:58 ` Sam Ravnborg
@ 2007-05-13 13:51 ` Atsushi Nemoto
2007-05-14 7:27 ` Franck Bui-Huu
1 sibling, 0 replies; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-13 13:51 UTC (permalink / raw)
To: sam; +Cc: vagabon.xyz, linux-mips, ralf
On Sat, 12 May 2007 20:58:54 +0200, Sam Ravnborg <sam@ravnborg.org> wrote:
> > Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
>
> This is overengineered. The only reason to make the syscall check
> for each and every build was that this was easy and the missing syscalls
> are easy to spot during a normal build.
> But checking all combinations is just not worth it.
> The arch responsible are assumed to build for the different architectures
> once in a while so a missing syscall are likely to be detected anyway.
>
> We cannot run each and every consistency check in all combinations
> for each build - that would end in only build noise.
Well, 64-bit MIPS has three ABIs and each ABI has complete set of
syscalls. So a result of default "missing-syscalls" target (which is
for N64 ABI) is not useful at all for other two ABIs.
I think checking them is worth even if the S/N ratio was quite low.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-12 18:58 ` Sam Ravnborg
2007-05-13 13:51 ` Atsushi Nemoto
@ 2007-05-14 7:27 ` Franck Bui-Huu
1 sibling, 0 replies; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-14 7:27 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Atsushi Nemoto, linux-mips, ralf
On 5/12/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Sun, May 13, 2007 at 01:47:13AM +0900, Atsushi Nemoto wrote:
> > Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
>
> This is overengineered. The only reason to make the syscall check
> for each and every build was that this was easy and the missing syscalls
> are easy to spot during a normal build.
Well perhaps we shouldn't check for missing syscalls for a normal
build. After all, it's going to be used by arch maintainers or kernel
developpers once in a while (maybe every releases). So why not make it
optional ?
$ make CHECK_SYSCALL=1
or
$ make check-syscalls
> But checking all combinations is just not worth it.
> The arch responsible are assumed to build for the different architectures
> once in a while so a missing syscall are likely to be detected anyway.
>
> We cannot run each and every consistency check in all combinations
> for each build - that would end in only build noise.
>
That's not exactly the case, see Atsushi's reply.
--
Franck
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-12 16:47 ` Atsushi Nemoto
2007-05-12 18:58 ` Sam Ravnborg
@ 2007-05-14 7:23 ` Franck Bui-Huu
2007-05-14 7:46 ` Atsushi Nemoto
2007-05-29 15:38 ` Atsushi Nemoto
2 siblings, 1 reply; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-14 7:23 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
Atsushi,
On 5/12/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index f450066..5aa0f41 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -702,6 +702,19 @@ vmlinux.srec: $(vmlinux-32)
> CLEAN_FILES += vmlinux.ecoff \
> vmlinux.srec
>
> +PHONY += arch-missing-syscalls
> +arch-missing-syscalls: prepare1
Why did you add 'prepare1' dependency ?
Thanks
--
Franck
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 7:23 ` Franck Bui-Huu
@ 2007-05-14 7:46 ` Atsushi Nemoto
2007-05-14 7:55 ` Franck Bui-Huu
0 siblings, 1 reply; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-14 7:46 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Mon, 14 May 2007 09:23:08 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> > +arch-missing-syscalls: prepare1
>
> Why did you add 'prepare1' dependency ?
Without that, fresh build will fail because missing-syscalls target
requires include/asm, etc.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 7:46 ` Atsushi Nemoto
@ 2007-05-14 7:55 ` Franck Bui-Huu
2007-05-14 8:07 ` Atsushi Nemoto
0 siblings, 1 reply; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-14 7:55 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
On 5/14/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 14 May 2007 09:23:08 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> > > +arch-missing-syscalls: prepare1
> >
> > Why did you add 'prepare1' dependency ?
>
> Without that, fresh build will fail because missing-syscalls target
> requires include/asm, etc.
>
yes but from top makefile, we already have this depedency:
$ grep archprepare: Makefile
archprepare: prepare1 scripts_basic
--
Franck
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 7:55 ` Franck Bui-Huu
@ 2007-05-14 8:07 ` Atsushi Nemoto
2007-05-14 10:32 ` Franck Bui-Huu
0 siblings, 1 reply; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-14 8:07 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Mon, 14 May 2007 09:55:01 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> > Without that, fresh build will fail because missing-syscalls target
> > requires include/asm, etc.
>
> yes but from top makefile, we already have this depedency:
>
> $ grep archprepare: Makefile
> archprepare: prepare1 scripts_basic
Yes, and arch Makefile is included _before_ the line. So "make" will
try to build arch-missing-syscalls before prepare1.
We must tell "make" to build prepare1 _before_ arch-missing-syscalls.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 8:07 ` Atsushi Nemoto
@ 2007-05-14 10:32 ` Franck Bui-Huu
2007-05-14 10:42 ` Franck Bui-Huu
2007-05-14 13:29 ` Atsushi Nemoto
0 siblings, 2 replies; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-14 10:32 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
On 5/14/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 14 May 2007 09:55:01 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> > > Without that, fresh build will fail because missing-syscalls target
> > > requires include/asm, etc.
> >
> > yes but from top makefile, we already have this depedency:
> >
> > $ grep archprepare: Makefile
> > archprepare: prepare1 scripts_basic
>
> Yes, and arch Makefile is included _before_ the line. So "make" will
> try to build arch-missing-syscalls before prepare1.
>
hmm okay. But this depedency is not really nice IMHO...
Something weird is that if you do this on top of your patch, it seems to work:
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 5aa0f41..04a57f9 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -713,7 +713,7 @@ ifdef CONFIG_MIPS32_O32
$(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
endif
-archprepare: arch-missing-syscalls
+prepare0: arch-missing-syscalls
archclean:
@$(MAKE) $(clean)=arch/mips/boot
It seems that we can't rely on the order of the execution of megerd
prerequisites...
--
Franck
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 10:32 ` Franck Bui-Huu
@ 2007-05-14 10:42 ` Franck Bui-Huu
2007-05-14 13:29 ` Atsushi Nemoto
1 sibling, 0 replies; 20+ messages in thread
From: Franck Bui-Huu @ 2007-05-14 10:42 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf, sam
On 5/14/07, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 5aa0f41..04a57f9 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -713,7 +713,7 @@ ifdef CONFIG_MIPS32_O32
> $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
> endif
>
> -archprepare: arch-missing-syscalls
> +prepare0: arch-missing-syscalls
>
> archclean:
> @$(MAKE) $(clean)=arch/mips/boot
>
of course with "prepare"1 prerequisite has been removed too:
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 5aa0f41..151a44c 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -703,7 +703,7 @@ CLEAN_FILES += vmlinux.ecoff \
vmlinux.srec
PHONY += arch-missing-syscalls
-arch-missing-syscalls: prepare1
+arch-missing-syscalls:
ifdef CONFIG_MIPS32_N32
@echo ' Checking missing-syscalls for N32'
$(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
@@ -713,7 +713,7 @@ ifdef CONFIG_MIPS32_O32
$(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
endif
-archprepare: arch-missing-syscalls
+prepare0: arch-missing-syscalls
archclean:
@$(MAKE) $(clean)=arch/mips/boot
--
Franck
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-14 10:32 ` Franck Bui-Huu
2007-05-14 10:42 ` Franck Bui-Huu
@ 2007-05-14 13:29 ` Atsushi Nemoto
1 sibling, 0 replies; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-14 13:29 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Mon, 14 May 2007 12:32:51 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:
> It seems that we can't rely on the order of the execution of megerd
> prerequisites...
Hmm, alphabetical order or something? Anyway, adding the prerequisite
for arch-missing-syscalls should work though it seems a bit ugly.
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
2007-05-12 16:47 ` Atsushi Nemoto
2007-05-12 18:58 ` Sam Ravnborg
2007-05-14 7:23 ` Franck Bui-Huu
@ 2007-05-29 15:38 ` Atsushi Nemoto
2007-05-31 12:14 ` Ralf Baechle
2 siblings, 1 reply; 20+ messages in thread
From: Atsushi Nemoto @ 2007-05-29 15:38 UTC (permalink / raw)
To: vagabon.xyz; +Cc: linux-mips, ralf, sam
On Sun, 13 May 2007 01:47:13 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > But I still think that (a) you shouldn't put any command in
> > 'archprepare' multiple rule (b) you should move this rule from the
> > cleaning targets.
>
> Oh, I missed those points. Revised again.
Well, I changed my mind. I suppose putting commands on archprepare in
arch's Makefile would be OK while the toplevel Makefile gives only a
dependency rule for the target.
Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32
Use standard missing-syscalls with EXTRA_CFLAGS instead of duplicating
the command. And move the archprepare rule before the archclean rule.
Suggested by Franck Bui-Huu. Also add "echo" to show the target ABI.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index f450066..2b19605 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -702,6 +702,16 @@ vmlinux.srec: $(vmlinux-32)
CLEAN_FILES += vmlinux.ecoff \
vmlinux.srec
+archprepare:
+ifdef CONFIG_MIPS32_N32
+ @echo ' Checking missing-syscalls for N32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
+endif
+ifdef CONFIG_MIPS32_O32
+ @echo ' Checking missing-syscalls for O32'
+ $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
+endif
+
archclean:
@$(MAKE) $(clean)=arch/mips/boot
@$(MAKE) $(clean)=arch/mips/lasat
@@ -709,25 +719,3 @@ archclean:
CLEAN_FILES += vmlinux.32 \
vmlinux.64 \
vmlinux.ecoff
-
-quiet_cmd_syscalls_n32 = CALL-N32 $<
- cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
-
-quiet_cmd_syscalls_o32 = CALL-O32 $<
- cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
-
-PHONY += missing-syscalls-n32 missing-syscalls-o32
-
-missing-syscalls-n32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_n32)
-
-missing-syscalls-o32: scripts/checksyscalls.sh FORCE
- $(call cmd,syscalls_o32)
-
-archprepare:
-ifdef CONFIG_MIPS32_N32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
-endif
-ifdef CONFIG_MIPS32_O32
- $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
-endif
^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2007-05-31 12:14 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-10 16:02 [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI Atsushi Nemoto
2007-05-11 10:49 ` Ralf Baechle
2007-05-11 12:14 ` Franck Bui-Huu
2007-05-11 13:51 ` Thiemo Seufer
2007-05-11 14:41 ` Atsushi Nemoto
2007-05-11 15:59 ` Atsushi Nemoto
2007-05-11 19:23 ` Franck Bui-Huu
2007-05-12 16:47 ` Atsushi Nemoto
2007-05-12 18:58 ` Sam Ravnborg
2007-05-13 13:51 ` Atsushi Nemoto
2007-05-14 7:27 ` Franck Bui-Huu
2007-05-14 7:23 ` Franck Bui-Huu
2007-05-14 7:46 ` Atsushi Nemoto
2007-05-14 7:55 ` Franck Bui-Huu
2007-05-14 8:07 ` Atsushi Nemoto
2007-05-14 10:32 ` Franck Bui-Huu
2007-05-14 10:42 ` Franck Bui-Huu
2007-05-14 13:29 ` Atsushi Nemoto
2007-05-29 15:38 ` Atsushi Nemoto
2007-05-31 12:14 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox