Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] Move do_default_vi inside of CONFIG_CPU_MIPSR2_SRS
@ 2007-05-21 14:45 Atsushi Nemoto
  2007-05-21 14:56 ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2007-05-21 14:45 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

This fixes the warning:

arch/mips/kernel/traps.c:931: warning: 'do_default_vi' defined but not used

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 200de02..3f58b6a 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -927,12 +927,6 @@ asmlinkage void do_reserved(struct pt_regs *regs)
 	      (regs->cp0_cause & 0x7f) >> 2);
 }
 
-static asmlinkage void do_default_vi(void)
-{
-	show_regs(get_irq_regs());
-	panic("Caught unexpected vectored interrupt.");
-}
-
 /*
  * Some MIPS CPUs can enable/disable for cache parity detection, but do
  * it different ways.
@@ -1128,6 +1122,12 @@ void mips_srs_free(int set)
 	clear_bit(set, &sr->sr_allocated);
 }
 
+static asmlinkage void do_default_vi(void)
+{
+	show_regs(get_irq_regs());
+	panic("Caught unexpected vectored interrupt.");
+}
+
 static void *set_vi_srs_handler(int n, vi_handler_t addr, int srs)
 {
 	unsigned long handler;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Move do_default_vi inside of CONFIG_CPU_MIPSR2_SRS
  2007-05-21 14:45 [PATCH] Move do_default_vi inside of CONFIG_CPU_MIPSR2_SRS Atsushi Nemoto
@ 2007-05-21 14:56 ` Ralf Baechle
  2007-05-21 15:06   ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2007-05-21 14:56 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Mon, May 21, 2007 at 11:45:38PM +0900, Atsushi Nemoto wrote:

> This fixes the warning:
> 
> arch/mips/kernel/traps.c:931: warning: 'do_default_vi' defined but not used

Applied.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Move do_default_vi inside of CONFIG_CPU_MIPSR2_SRS
  2007-05-21 14:56 ` Ralf Baechle
@ 2007-05-21 15:06   ` Ralf Baechle
  0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2007-05-21 15:06 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Mon, May 21, 2007 at 04:56:15PM +0200, Ralf Baechle wrote:

> > This fixes the warning:
> > 
> > arch/mips/kernel/traps.c:931: warning: 'do_default_vi' defined but not used
> 
> Applied.

The patch isn't quite right, it may fix the warning but it confuses
vectored interrupts and shadow registers.  Something to sort later ...

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-05-21 15:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-21 14:45 [PATCH] Move do_default_vi inside of CONFIG_CPU_MIPSR2_SRS Atsushi Nemoto
2007-05-21 14:56 ` Ralf Baechle
2007-05-21 15:06   ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox