* [PATCH 1/2] Add MIPS generic GPIO support
@ 2007-05-19 19:51 Florian Fainelli
2007-05-20 9:23 ` Yoichi Yuasa
0 siblings, 1 reply; 11+ messages in thread
From: Florian Fainelli @ 2007-05-19 19:51 UTC (permalink / raw)
To: linux-mips
[-- Attachment #1.1: Type: text/plain, Size: 137 bytes --]
This patch adds support for the generic GPIO API to MIPS boards.
--
Signed-off-by: Florian Fainelli <florian.fainelli@telecomint.eu>
[-- Attachment #1.2: mips-gpio.patch --]
[-- Type: text/plain, Size: 340 bytes --]
--- linux-2.6.21.1/include/asm-mips/gpio.h 1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.21.1.new/include/asm-mips/gpio.h 2007-05-19 21:34:14.000000000 +0200
@@ -0,0 +1,7 @@
+#ifndef _ASM_MIPS_GPIO_H
+#define _ASM_MIPS_GPIO_H
+
+/* Not all MIPS platforms support this API */
+#include <asm-generic/gpio.h>
+
+#endif /* _ASM_MIPS_GPIO_H
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] Add MIPS generic GPIO support
2007-05-19 19:51 [PATCH 1/2] Add MIPS generic GPIO support Florian Fainelli
@ 2007-05-20 9:23 ` Yoichi Yuasa
2007-05-20 15:12 ` Atsushi Nemoto
0 siblings, 1 reply; 11+ messages in thread
From: Yoichi Yuasa @ 2007-05-20 9:23 UTC (permalink / raw)
To: Florian Fainelli; +Cc: yoichi_yuasa, linux-mips, Ralf Baechle
On Sat, 19 May 2007 21:51:37 +0200
Florian Fainelli <florian.fainelli@telecomint.eu> wrote:
> This patch adds support for the generic GPIO API to MIPS boards.
Your patch is effective to the target that doesn't support GPIO.
This is better.
Yoichi
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/gpio.h gpio/include/asm-mips/gpio.h
--- gpio-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
+++ gpio/include/asm-mips/gpio.h 2007-05-20 17:21:36.332456000 +0900
@@ -0,0 +1,6 @@
+#ifndef __ASM_MIPS_GPIO_H
+#define __ASM_MIPS_GPIO_H
+
+#include <gpio.h>
+
+#endif /* __ASM_MIPS_GPIO_H */
diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/mach-generic/gpio.h gpio/include/asm-mips/mach-generic/gpio.h
--- gpio-orig/include/asm-mips/mach-generic/gpio.h 1970-01-01 09:00:00.000000000 +0900
+++ gpio/include/asm-mips/mach-generic/gpio.h 2007-05-20 17:24:07.401897250 +0900
@@ -0,0 +1,6 @@
+#ifndef __ASM_MACH_GENERIC_GPIO_H
+#define __ASM_MACH_GENERIC_GPIO_H
+
+/* no GPIO support */
+
+#endif /* __ASM_MACH_GENERIC_GPIO_H */
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] Add MIPS generic GPIO support
2007-05-20 9:23 ` Yoichi Yuasa
@ 2007-05-20 15:12 ` Atsushi Nemoto
2007-05-21 7:13 ` Yoichi Yuasa
0 siblings, 1 reply; 11+ messages in thread
From: Atsushi Nemoto @ 2007-05-20 15:12 UTC (permalink / raw)
To: yoichi_yuasa; +Cc: florian.fainelli, linux-mips, ralf
On Sun, 20 May 2007 18:23:01 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/gpio.h gpio/include/asm-mips/gpio.h
> --- gpio-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
> +++ gpio/include/asm-mips/gpio.h 2007-05-20 17:21:36.332456000 +0900
> @@ -0,0 +1,6 @@
> +#ifndef __ASM_MIPS_GPIO_H
> +#define __ASM_MIPS_GPIO_H
> +
> +#include <gpio.h>
> +
> +#endif /* __ASM_MIPS_GPIO_H */
This looks good for me.
> diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/mach-generic/gpio.h gpio/include/asm-mips/mach-generic/gpio.h
> --- gpio-orig/include/asm-mips/mach-generic/gpio.h 1970-01-01 09:00:00.000000000 +0900
> +++ gpio/include/asm-mips/mach-generic/gpio.h 2007-05-20 17:24:07.401897250 +0900
> @@ -0,0 +1,6 @@
> +#ifndef __ASM_MACH_GENERIC_GPIO_H
> +#define __ASM_MACH_GENERIC_GPIO_H
> +
> +/* no GPIO support */
> +
> +#endif /* __ASM_MACH_GENERIC_GPIO_H */
But is this really needed? I can not see any point of this empty gpio.h ...
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] Add MIPS generic GPIO support
2007-05-20 15:12 ` Atsushi Nemoto
@ 2007-05-21 7:13 ` Yoichi Yuasa
2007-05-21 7:29 ` [PATCH] " Yoichi Yuasa
0 siblings, 1 reply; 11+ messages in thread
From: Yoichi Yuasa @ 2007-05-21 7:13 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: yoichi_yuasa, florian.fainelli, linux-mips, ralf
On Mon, 21 May 2007 00:12:38 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Sun, 20 May 2007 18:23:01 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/gpio.h gpio/include/asm-mips/gpio.h
> > --- gpio-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
> > +++ gpio/include/asm-mips/gpio.h 2007-05-20 17:21:36.332456000 +0900
> > @@ -0,0 +1,6 @@
> > +#ifndef __ASM_MIPS_GPIO_H
> > +#define __ASM_MIPS_GPIO_H
> > +
> > +#include <gpio.h>
> > +
> > +#endif /* __ASM_MIPS_GPIO_H */
>
> This looks good for me.
>
> > diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/mach-generic/gpio.h gpio/include/asm-mips/mach-generic/gpio.h
> > --- gpio-orig/include/asm-mips/mach-generic/gpio.h 1970-01-01 09:00:00.000000000 +0900
> > +++ gpio/include/asm-mips/mach-generic/gpio.h 2007-05-20 17:24:07.401897250 +0900
> > @@ -0,0 +1,6 @@
> > +#ifndef __ASM_MACH_GENERIC_GPIO_H
> > +#define __ASM_MACH_GENERIC_GPIO_H
> > +
> > +/* no GPIO support */
> > +
> > +#endif /* __ASM_MACH_GENERIC_GPIO_H */
>
> But is this really needed? I can not see any point of this empty gpio.h ...
No, it is not must.
I'll update it soon.
Yoichi
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] Add MIPS generic GPIO support
2007-05-21 7:13 ` Yoichi Yuasa
@ 2007-05-21 7:29 ` Yoichi Yuasa
2007-05-21 14:12 ` Atsushi Nemoto
0 siblings, 1 reply; 11+ messages in thread
From: Yoichi Yuasa @ 2007-05-21 7:29 UTC (permalink / raw)
To: Ralf Baechle; +Cc: yoichi_yuasa, anemo, florian.fainelli, linux-mips
Hi Ralf,
This patch has added support for the generic GPIO API header file to MIPS.
Yoichi
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X mips/Documentation/dontdiff mips-orig/include/asm-mips/gpio.h mips/include/asm-mips/gpio.h
--- mips-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
+++ mips/include/asm-mips/gpio.h 2007-05-21 16:19:05.720583500 +0900
@@ -0,0 +1,6 @@
+#ifndef __ASM_MIPS_GPIO_H
+#define __ASM_MIPS_GPIO_H
+
+#include <gpio.h>
+
+#endif /* __ASM_MIPS_GPIO_H */
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Add MIPS generic GPIO support
2007-05-21 7:29 ` [PATCH] " Yoichi Yuasa
@ 2007-05-21 14:12 ` Atsushi Nemoto
2007-05-21 15:05 ` [PATCH UPDATE] " Yoichi Yuasa
0 siblings, 1 reply; 11+ messages in thread
From: Atsushi Nemoto @ 2007-05-21 14:12 UTC (permalink / raw)
To: yoichi_yuasa; +Cc: ralf, florian.fainelli, linux-mips
On Mon, 21 May 2007 16:29:35 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> This patch has added support for the generic GPIO API header file to MIPS.
With the change, adding these lines to Kconfig would be better.
config GENERIC_GPIO
bool
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH UPDATE] Add MIPS generic GPIO support
2007-05-21 14:12 ` Atsushi Nemoto
@ 2007-05-21 15:05 ` Yoichi Yuasa
2007-05-21 15:20 ` Atsushi Nemoto
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Yoichi Yuasa @ 2007-05-21 15:05 UTC (permalink / raw)
To: Ralf Baechle; +Cc: yoichi_yuasa, florian.fainelli, linux-mips, Atsushi Nemoto
On Mon, 21 May 2007 23:12:00 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 21 May 2007 16:29:35 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > This patch has added support for the generic GPIO API header file to MIPS.
>
> With the change, adding these lines to Kconfig would be better.
>
> config GENERIC_GPIO
> bool
Atsushi, thank you for your comment.
This patch has added support for the generic GPIO API to MIPS.
Yoichi
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/Kconfig mips/arch/mips/Kconfig
--- mips-orig/arch/mips/Kconfig 2007-05-21 16:08:48.846031250 +0900
+++ mips/arch/mips/Kconfig 2007-05-21 23:56:57.784356000 +0900
@@ -778,6 +778,9 @@ config GENERIC_ISA_DMA_SUPPORT_BROKEN
bool
select ZONE_DMA
+config GENERIC_GPIO
+ bool
+
#
# Endianess selection. Sufficiently obscure so many users don't know what to
# answer,so we try hard to limit the available choices. Also the use of a
diff -pruN -X mips/Documentation/dontdiff mips-orig/include/asm-mips/gpio.h mips/include/asm-mips/gpio.h
--- mips-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
+++ mips/include/asm-mips/gpio.h 2007-05-21 17:07:51.769161250 +0900
@@ -0,0 +1,6 @@
+#ifndef __ASM_MIPS_GPIO_H
+#define __ASM_MIPS_GPIO_H
+
+#include <gpio.h>
+
+#endif /* __ASM_MIPS_GPIO_H */
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH UPDATE] Add MIPS generic GPIO support
2007-05-21 15:05 ` [PATCH UPDATE] " Yoichi Yuasa
@ 2007-05-21 15:20 ` Atsushi Nemoto
2007-05-21 21:31 ` Geert Uytterhoeven
2007-05-22 14:39 ` Ralf Baechle
2 siblings, 0 replies; 11+ messages in thread
From: Atsushi Nemoto @ 2007-05-21 15:20 UTC (permalink / raw)
To: yoichi_yuasa; +Cc: ralf, florian.fainelli, linux-mips
On Tue, 22 May 2007 00:05:58 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> This patch has added support for the generic GPIO API to MIPS.
>
> Yoichi
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Thank you for quick update.
Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH UPDATE] Add MIPS generic GPIO support
2007-05-21 15:05 ` [PATCH UPDATE] " Yoichi Yuasa
2007-05-21 15:20 ` Atsushi Nemoto
@ 2007-05-21 21:31 ` Geert Uytterhoeven
2007-05-21 22:15 ` Yoichi Yuasa
2007-05-22 14:39 ` Ralf Baechle
2 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2007-05-21 21:31 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: Ralf Baechle, florian.fainelli, linux-mips, Atsushi Nemoto
On Tue, 22 May 2007, Yoichi Yuasa wrote:
> --- mips-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
> +++ mips/include/asm-mips/gpio.h 2007-05-21 17:07:51.769161250 +0900
> @@ -0,0 +1,6 @@
> +#ifndef __ASM_MIPS_GPIO_H
> +#define __ASM_MIPS_GPIO_H
> +
> +#include <gpio.h>
^^^^^^^^
> +
> +#endif /* __ASM_MIPS_GPIO_H */
Just wondering, where is it supposed to find <gpio.h>?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH UPDATE] Add MIPS generic GPIO support
2007-05-21 21:31 ` Geert Uytterhoeven
@ 2007-05-21 22:15 ` Yoichi Yuasa
0 siblings, 0 replies; 11+ messages in thread
From: Yoichi Yuasa @ 2007-05-21 22:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: yoichi_yuasa, ralf, florian.fainelli, linux-mips, anemo
On Mon, 21 May 2007 23:31:44 +0200 (CEST)
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, 22 May 2007, Yoichi Yuasa wrote:
> > --- mips-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
> > +++ mips/include/asm-mips/gpio.h 2007-05-21 17:07:51.769161250 +0900
> > @@ -0,0 +1,6 @@
> > +#ifndef __ASM_MIPS_GPIO_H
> > +#define __ASM_MIPS_GPIO_H
> > +
> > +#include <gpio.h>
> ^^^^^^^^
> > +
> > +#endif /* __ASM_MIPS_GPIO_H */
>
> Just wondering, where is it supposed to find <gpio.h>?
It should be include/asm-mips/mach-*/gpio.h .
Yoichi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH UPDATE] Add MIPS generic GPIO support
2007-05-21 15:05 ` [PATCH UPDATE] " Yoichi Yuasa
2007-05-21 15:20 ` Atsushi Nemoto
2007-05-21 21:31 ` Geert Uytterhoeven
@ 2007-05-22 14:39 ` Ralf Baechle
2 siblings, 0 replies; 11+ messages in thread
From: Ralf Baechle @ 2007-05-22 14:39 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: florian.fainelli, linux-mips, Atsushi Nemoto
On Tue, May 22, 2007 at 12:05:58AM +0900, Yoichi Yuasa wrote:
> On Mon, 21 May 2007 23:12:00 +0900 (JST)
> Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>
> > On Mon, 21 May 2007 16:29:35 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > > This patch has added support for the generic GPIO API header file to MIPS.
> >
> > With the change, adding these lines to Kconfig would be better.
> >
> > config GENERIC_GPIO
> > bool
>
> Atsushi, thank you for your comment.
>
> This patch has added support for the generic GPIO API to MIPS.
Okay. Since no platform is currently setting I've dropped this into the
2.6.23 patch queue.
Thanks,
Ralf
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2007-05-22 14:39 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-19 19:51 [PATCH 1/2] Add MIPS generic GPIO support Florian Fainelli
2007-05-20 9:23 ` Yoichi Yuasa
2007-05-20 15:12 ` Atsushi Nemoto
2007-05-21 7:13 ` Yoichi Yuasa
2007-05-21 7:29 ` [PATCH] " Yoichi Yuasa
2007-05-21 14:12 ` Atsushi Nemoto
2007-05-21 15:05 ` [PATCH UPDATE] " Yoichi Yuasa
2007-05-21 15:20 ` Atsushi Nemoto
2007-05-21 21:31 ` Geert Uytterhoeven
2007-05-21 22:15 ` Yoichi Yuasa
2007-05-22 14:39 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox