[PATCH][MIPS] fix pb1500 reg B access

Linux MIPS Architecture development
 help / color / mirror / Atom feed

* [PATCH][MIPS] fix pb1500 reg B access
@ 2007-05-28 14:26 Yoichi Yuasa
  2007-05-29 10:35 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2007-05-28 14:26 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yoichi_yuasa, linux-mips

Hi Ralf,

I think that au_readl() is correct here.

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X generic/Documentation/dontdiff generic-orig/arch/mips/au1000/pb1500/board_setup.c generic/arch/mips/au1000/pb1500/board_setup.c
--- generic-orig/arch/mips/au1000/pb1500/board_setup.c	2007-03-23 11:00:22.474631250 +0900
+++ generic/arch/mips/au1000/pb1500/board_setup.c	2007-03-23 17:09:27.070322250 +0900
@@ -125,7 +125,7 @@ void __init board_setup(void)
 		au_writel((au_readl(0xac000028) | 0x20), 0xac000028);
 	}
 	/* Put the clock in BCD mode */
-	if (readl(0xac00002C) & 0x4) { /* reg B */
+	if (au_readl(0xac00002C) & 0x4) { /* reg B */
 		au_writel(au_readl(0xac00002c) & ~0x4, 0xac00002c);
 		au_sync();
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][MIPS] fix pb1500 reg B access
  2007-05-28 14:26 [PATCH][MIPS] fix pb1500 reg B access Yoichi Yuasa
@ 2007-05-29 10:35 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-05-29 10:35 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: linux-mips

On Mon, May 28, 2007 at 11:26:56PM +0900, Yoichi Yuasa wrote:

> I think that au_readl() is correct here.

Yes - even though the difference is only cosmetic and au_readl() etc.
operations essentially are equivalent to __raw_readX / __raw_writeX anyway
(or their modern equivalents), so maybe the should simply be replaced.

Anyway, applied.  Thanks,

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-31 10:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-28 14:26 [PATCH][MIPS] fix pb1500 reg B access Yoichi Yuasa
2007-05-29 10:35 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox