* [PATCH] die(): Properly declare as non-returning
@ 2007-05-29 14:03 Maciej W. Rozycki
2007-05-31 12:09 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2007-05-29 14:03 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
This marks the declaration of die() correctly, removing "control reaches
end of non-void function" warnings from non-void functions that die() at
the end.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
I've noticed there is an ongoing discussion about the use of NORET_TYPE
and ATTRIB_NORET, but until that is resolved this change is useful.
Please apply.
Maciej
patch-mips-2.6.21-20070502-die-noret-0
diff -up --recursive --new-file linux-mips-2.6.21-20070502.macro/include/asm-mips/ptrace.h linux-mips-2.6.21-20070502/include/asm-mips/ptrace.h
--- linux-mips-2.6.21-20070502.macro/include/asm-mips/ptrace.h 2007-02-21 05:57:58.000000000 +0000
+++ linux-mips-2.6.21-20070502/include/asm-mips/ptrace.h 2007-05-27 21:15:00.000000000 +0000
@@ -86,7 +86,7 @@ struct pt_regs {
extern asmlinkage void do_syscall_trace(struct pt_regs *regs, int entryexit);
-extern NORET_TYPE void die(const char *, struct pt_regs *);
+extern NORET_TYPE void die(const char *, struct pt_regs *) ATTRIB_NORET;
static inline void die_if_kernel(const char *str, struct pt_regs *regs)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] die(): Properly declare as non-returning
2007-05-29 14:03 [PATCH] die(): Properly declare as non-returning Maciej W. Rozycki
@ 2007-05-31 12:09 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-05-31 12:09 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: linux-mips
On Tue, May 29, 2007 at 03:03:56PM +0100, Maciej W. Rozycki wrote:
> This marks the declaration of die() correctly, removing "control reaches
> end of non-void function" warnings from non-void functions that die() at
> the end.
Applied. Thanks,
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-31 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-29 14:03 [PATCH] die(): Properly declare as non-returning Maciej W. Rozycki
2007-05-31 12:09 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox