Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: "Kevin D. Kissell" <kevink@mips.com>
Cc: linux-mips@linux-mips.org
Subject: Re: dead(?) MIPS config stuff
Date: Thu, 5 Jul 2007 17:45:28 +0100	[thread overview]
Message-ID: <20070705164528.GA23340@linux-mips.org> (raw)
In-Reply-To: <20070705163658.GA22652@linux-mips.org>

On Thu, Jul 05, 2007 at 05:36:58PM +0100, Ralf Baechle wrote:

> All this email was about were kernel configuration options that can't be
> enabled for some reason.  Of course these automated checkers such as
> Robert's make the assumption that the CONFIG_* preprocessor namespace
> is rserved for the Kconfig system.  In this particular case the reason
> is quite simple:
> 
> > arch/mips/kernel/process.c:54:#ifdef CONFIG_SMTC_IDLE_HOOK_DEBUG
> > arch/mips/Kconfig.debug:40:config CONFIG_SMTC_IDLE_HOOK_DEBUG
> 
> The kconfig system itself does prefix names with CONFIG_ so kconfig
> ends up defining CONFIG_CONFIG_SMTC_IDLE_HOOK_DEBUG (are we stuttuttering?)


From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 5 Jul 2007 17:39:48 +0100
Subject: [MIPS] SMTC: Fix cut'n'paste bug in Kconfig.debug

This effectivly turned the SMTC_IDLE_HOOK_DEBUG debug option into a no-op.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index 72d5c19..3efe117 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -37,7 +37,7 @@ config DEBUG_STACK_USAGE
 
 	  This option will slow down process creation somewhat.
 
-config CONFIG_SMTC_IDLE_HOOK_DEBUG
+config SMTC_IDLE_HOOK_DEBUG
 	bool "Enable additional debug checks before going into CPU idle loop"
 	depends on DEBUG_KERNEL && MIPS_MT_SMTC
 	help

      reply	other threads:[~2007-07-05 16:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 14:46 dead(?) MIPS config stuff Ralf Baechle
2007-07-05 15:01 ` Robert P. J. Day
2007-07-05 15:26   ` Ralf Baechle
2007-07-05 15:26     ` Robert P. J. Day
2007-07-05 15:27 ` Maciej W. Rozycki
2007-07-05 16:03 ` Sergei Shtylyov
2007-07-12 16:56   ` Atsushi Nemoto
2007-07-05 16:23 ` Kevin D. Kissell
2007-07-05 16:23   ` Kevin D. Kissell
2007-07-05 16:28   ` Robert P. J. Day
2007-07-05 16:37     ` Ralf Baechle
2007-07-05 16:48       ` Geert Uytterhoeven
2007-07-05 16:36   ` Ralf Baechle
2007-07-05 16:45     ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070705164528.GA23340@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=kevink@mips.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox