From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Thiemo Seufer <ths@networkno.de>, linux-mips@linux-mips.org
Subject: Re: [PATCH] bcm1480 serial build fix
Date: Mon, 23 Jul 2007 14:21:56 +0100 [thread overview]
Message-ID: <20070723132156.GD31040@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64N.0707231353030.13557@blysk.ds.pg.gda.pl>
On Mon, Jul 23, 2007 at 02:00:16PM +0100, Maciej W. Rozycki wrote:
> Aren't all the bits in "bcm1480_regs.h" meant to be prefixed with
> BCM1480_DUART? If these are to be the same as for the BCM1250, then they
> can probably be defined "in sb1250_regs.h" unconditionally.
>
> These headers are a horrible mess anyway -- a single definition should be
> enough to access the two DUARTs the BCM1480 seems to have...
The headers are autogenerated by Broadcom; they got some header-o-matic
which from a common source base will generate headers for Linux and
several other operating systems by adding (C) headers etc. Which makes
sorting them tricky ...
Ralf
next prev parent reply other threads:[~2007-07-23 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 7:55 [PATCH] bcm1480 serial build fix Thiemo Seufer
2007-07-23 13:00 ` Maciej W. Rozycki
2007-07-23 13:21 ` Ralf Baechle [this message]
2007-07-23 15:07 ` Maciej W. Rozycki
2007-07-23 13:44 ` Thiemo Seufer
2007-07-23 15:11 ` Maciej W. Rozycki
2007-08-24 14:32 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723132156.GD31040@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox