From: Thiemo Seufer <ths@networkno.de>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] bcm1480 serial build fix
Date: Mon, 23 Jul 2007 14:44:32 +0100 [thread overview]
Message-ID: <20070723134431.GB18207@networkno.de> (raw)
In-Reply-To: <Pine.LNX.4.64N.0707231353030.13557@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
> On Sun, 22 Jul 2007, Thiemo Seufer wrote:
>
> > diff --git a/include/asm-mips/sibyte/bcm1480_regs.h b/include/asm-mips/sibyte/bcm1480_regs.h
> > index 2738c13..c34d36b 100644
> > --- a/include/asm-mips/sibyte/bcm1480_regs.h
> > +++ b/include/asm-mips/sibyte/bcm1480_regs.h
> > @@ -227,10 +227,15 @@
> > (A_BCM1480_DUART(chan) + \
> > BCM1480_DUART_CHANREG_SPACING * 3 + (reg))
> >
> > +#define DUART_IMRISR_SPACING 0x20
> > +#define DUART_INCHNG_SPACING 0x10
> > +
>
> Aren't all the bits in "bcm1480_regs.h" meant to be prefixed with
> BCM1480_DUART?
Appatenly not, guessing from the header's contents.
> If these are to be the same as for the BCM1250, then they
> can probably be defined "in sb1250_regs.h" unconditionally.
>
> These headers are a horrible mess anyway -- a single definition should be
> enough to access the two DUARTs the BCM1480 seems to have...
Indeed. I just took the path of least resistance to make it work again.
Thiemo
next prev parent reply other threads:[~2007-07-23 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 7:55 [PATCH] bcm1480 serial build fix Thiemo Seufer
2007-07-23 13:00 ` Maciej W. Rozycki
2007-07-23 13:21 ` Ralf Baechle
2007-07-23 15:07 ` Maciej W. Rozycki
2007-07-23 13:44 ` Thiemo Seufer [this message]
2007-07-23 15:11 ` Maciej W. Rozycki
2007-08-24 14:32 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723134431.GB18207@networkno.de \
--to=ths@networkno.de \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox