Linux MIPS Architecture development
 help / color / mirror / Atom feed
* A blind patch:)
@ 2007-07-30 15:32 Songmao Tian
  2007-07-30 17:18 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Songmao Tian @ 2007-07-30 15:32 UTC (permalink / raw)
  To: linux-mips, Ralf Baechle

commit 5fabf601a53079c182d5c25f6e850d6a7bd48988 is broken. since the 
regptr is disappeared in the signature of the function, I think the 
regptr is useless.


diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index bbf20ce..1b94eef 100644
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -281,9 +281,7 @@ static void emulate_load_store_insn(struct pt_regs 
*regs,
             : "r" (addr), "i" (-EFAULT));
         if (res)
             goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
         compute_return_epc(regs);
-        *regptr = value;
         break;
 #endif /* CONFIG_64BIT */
 
@@ -324,9 +322,7 @@ static void emulate_load_store_insn(struct pt_regs 
*regs,
             : "r" (addr), "i" (-EFAULT));
         if (res)
             goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
         compute_return_epc(regs);
-        *regptr = value;
         break;
 #endif /* CONFIG_64BIT */
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: A blind patch:)
  2007-07-30 15:32 A blind patch:) Songmao Tian
@ 2007-07-30 17:18 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-07-30 17:18 UTC (permalink / raw)
  To: Songmao Tian; +Cc: linux-mips

On Mon, Jul 30, 2007 at 11:32:44PM +0800, Songmao Tian wrote:

> commit 5fabf601a53079c182d5c25f6e850d6a7bd48988 is broken. since the 
> regptr is disappeared in the signature of the function, I think the 
> regptr is useless.

Indeed, you found a bug but your fix wasn't right.

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index bbf20ce..d34b1fb 100644
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -281,9 +281,8 @@ static void emulate_load_store_insn(struct pt_regs *regs,
 			: "r" (addr), "i" (-EFAULT));
 		if (res)
 			goto fault;
-		*regptr = &regs->regs[insn.i_format.rt];
 		compute_return_epc(regs);
-		*regptr = value;
+		regs->regs[insn.i_format.rt] = value;
 		break;
 #endif /* CONFIG_64BIT */
 
@@ -324,9 +323,8 @@ static void emulate_load_store_insn(struct pt_regs *regs,
 			: "r" (addr), "i" (-EFAULT));
 		if (res)
 			goto fault;
-		*regptr = &regs->regs[insn.i_format.rt];
 		compute_return_epc(regs);
-		*regptr = value;
+		regs->regs[insn.i_format.rt] = value;
 		break;
 #endif /* CONFIG_64BIT */
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-30 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-30 15:32 A blind patch:) Songmao Tian
2007-07-30 17:18 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox