[PATCH 4/5] Use -Werror on TX39/TX49 boards

[PATCH 4/5] Use -Werror on TX39/TX49 boards

[Atsushi Nemoto]

Now these directories can be built cleanly.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
 arch/mips/tx4927/common/Makefile           |    2 ++
 arch/mips/tx4927/toshiba_rbtx4927/Makefile |    2 ++
 arch/mips/tx4938/common/Makefile           |    1 +
 arch/mips/tx4938/toshiba_rbtx4938/Makefile |    2 ++
 4 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/mips/tx4927/common/Makefile b/arch/mips/tx4927/common/Makefile
index 9cb9535..1837578 100644
--- a/arch/mips/tx4927/common/Makefile
+++ b/arch/mips/tx4927/common/Makefile
@@ -10,3 +10,5 @@ obj-y	+= tx4927_prom.o tx4927_setup.o tx4927_irq.o
 
 obj-$(CONFIG_TOSHIBA_FPCIB0)	   += smsc_fdc37m81x.o
 obj-$(CONFIG_KGDB)                 += tx4927_dbgio.o
+
+EXTRA_CFLAGS += -Werror
diff --git a/arch/mips/tx4927/toshiba_rbtx4927/Makefile b/arch/mips/tx4927/toshiba_rbtx4927/Makefile
index 8a991f3..13f9672 100644
--- a/arch/mips/tx4927/toshiba_rbtx4927/Makefile
+++ b/arch/mips/tx4927/toshiba_rbtx4927/Makefile
@@ -1,3 +1,5 @@
 obj-y	+= toshiba_rbtx4927_prom.o
 obj-y	+= toshiba_rbtx4927_setup.o
 obj-y	+= toshiba_rbtx4927_irq.o
+
+EXTRA_CFLAGS += -Werror
diff --git a/arch/mips/tx4938/common/Makefile b/arch/mips/tx4938/common/Makefile
index 83cda51..8352eca 100644
--- a/arch/mips/tx4938/common/Makefile
+++ b/arch/mips/tx4938/common/Makefile
@@ -9,3 +9,4 @@
 obj-y	+= prom.o setup.o irq.o
 obj-$(CONFIG_KGDB) += dbgio.o
 
+EXTRA_CFLAGS += -Werror
diff --git a/arch/mips/tx4938/toshiba_rbtx4938/Makefile b/arch/mips/tx4938/toshiba_rbtx4938/Makefile
index 10c94e6..675bb1c 100644
--- a/arch/mips/tx4938/toshiba_rbtx4938/Makefile
+++ b/arch/mips/tx4938/toshiba_rbtx4938/Makefile
@@ -7,3 +7,5 @@
 #
 
 obj-y	+= prom.o setup.o irq.o spi_eeprom.o
+
+EXTRA_CFLAGS += -Werror

Re: [PATCH 4/5] Use -Werror on TX39/TX49 boards

[Ralf Baechle]

On Thu, Aug 02, 2007 at 11:36:17PM +0900, Atsushi Nemoto wrote:

Applied.

Re: [PATCH 4/5] Use -Werror on TX39/TX49 boards

[Christoph Hellwig]

On Thu, Aug 02, 2007 at 11:36:17PM +0900, Atsushi Nemoto wrote:
> Now these directories can be built cleanly.

Please don't.  Adding -Werror is a complete pain in the ass for people
using new compilers or when we get things like __deprecated or
__warn_unused warnings from headers.  We've dropped it again from
the various placed that had introduced this.

Re: [PATCH 4/5] Use -Werror on TX39/TX49 boards

[Ralf Baechle]

On Fri, Aug 03, 2007 at 03:25:50PM +0200, Christoph Hellwig wrote:

> Please don't.  Adding -Werror is a complete pain in the ass for people
> using new compilers or when we get things like __deprecated or
> __warn_unused warnings from headers.  We've dropped it again from
> the various placed that had introduced this.

It seems to crank up the the pain level to the point where people upgrade
their code :-)

  Ralf

Re: [PATCH 4/5] Use -Werror on TX39/TX49 boards

[Atsushi Nemoto]

On Fri, 3 Aug 2007 14:36:29 +0100, Ralf Baechle <ralf@linux-mips.org> wrote:
> > Please don't.  Adding -Werror is a complete pain in the ass for people
> > using new compilers or when we get things like __deprecated or
> > __warn_unused warnings from headers.  We've dropped it again from
> > the various placed that had introduced this.
> 
> It seems to crank up the the pain level to the point where people upgrade
> their code :-)

Well, I just followed recent MIPS trend ;) I don't mind if you dropped
them again.

---
Atsushi Nemoto

Re: [PATCH 4/5] Use -Werror on TX39/TX49 boards

[Ralf Baechle]

On Fri, Aug 03, 2007 at 11:30:21PM +0900, Atsushi Nemoto wrote:

> Well, I just followed recent MIPS trend ;) I don't mind if you dropped
> them again.

Ideally I'd like something that disables -Werror for -stable releases
and enables it during development releases.

  Ralf