From: Aurelien Jarno <aurelien@aurel32.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Felix Fietkau <nbd@openwrt.org>, Andrew Morton <akpm@osdl.org>,
linux-mips@linux-mips.org, Waldemar Brodkorb <wbx@openwrt.org>,
Florian Schirmer <jolt@tuxbox.org>
Subject: Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
Date: Mon, 6 Aug 2007 20:33:51 +0200 [thread overview]
Message-ID: <20070806183351.GC32465@hall.aurel32.net> (raw)
In-Reply-To: <200708062024.53952.mb@bu3sch.de>
On Mon, Aug 06, 2007 at 08:24:53PM +0200, Michael Buesch wrote:
> On Monday 06 August 2007, Felix Fietkau wrote:
> > Michael Buesch wrote:
> >
> > > Shouldn't we leave the PCICORE an option instead of force selecting
> > > it here?
> > > My WRT54G doesn't have a (usable) PCI core. So it would work
> > > without the driver for it.
> > > Especially on the small WAP54G disabling PCIcore support could
> > > be useful to reduce the kernel size.
> > Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> > the PCICORE option would be reasonable, since many 47xx devices do have pci.
>
> Yeah, probably a good idea.
>
I will send a new patch to fix that.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2007-08-06 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 15:09 [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
2007-08-06 18:09 ` Michael Buesch
2007-08-06 18:13 ` Felix Fietkau
2007-08-06 18:24 ` Michael Buesch
2007-08-06 18:33 ` Aurelien Jarno [this message]
2007-08-06 20:16 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig (v2) Aurelien Jarno
2007-08-06 20:18 ` Michael Buesch
2007-08-06 20:32 ` Florian Schirmer
2007-08-06 19:49 ` [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806183351.GC32465@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=akpm@osdl.org \
--cc=jolt@tuxbox.org \
--cc=linux-mips@linux-mips.org \
--cc=mb@bu3sch.de \
--cc=nbd@openwrt.org \
--cc=wbx@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox