Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

[Michael Buesch <mb@bu3sch.de>]

On Monday 06 August 2007, Aurelien Jarno wrote:
> The patch below against 2.6.23-rc1-mm2 adds a BCM947XX option to 
> Kconfig.
> 
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Waldemar Brodkorb <wbx@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Florian Schirmer <jolt@tuxbox.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -38,6 +38,22 @@
>  	  Lemote Fulong mini-PC board based on the Chinese Loongson-2E CPU and
>  	  an FPGA northbridge
>  
> +config BCM947XX
> +	bool "Support for BCM947xx based boards"
> +	select DMA_NONCOHERENT
> +	select HW_HAS_PCI

Not sure what this does.
My 47xx machines do _not_ have a PCI bus.

> +	select IRQ_CPU
> +	select SYS_HAS_CPU_MIPS32_R1
> +	select SYS_SUPPORTS_32BIT_KERNEL
> +	select SYS_SUPPORTS_LITTLE_ENDIAN
> +	select SSB
> +	select SSB_SERIAL
> +	select SSB_DRIVER_PCICORE
> +	select SSB_PCICORE_HOSTMODE

Shouldn't we leave the PCICORE an option instead of force selecting
it here?
My WRT54G doesn't have a (usable) PCI core. So it would work
without the driver for it.
Especially on the small WAP54G disabling PCIcore support could
be useful to reduce the kernel size.

> +	select GENERIC_GPIO
> +	help
> +	 Support for BCM947xx based boards
> +
>  config MACH_ALCHEMY
>  	bool "Alchemy processor based machines"
>