* Re: [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus.
[not found] <S20023984AbXHXBUC/20070824012002Z+18840@ftp.linux-mips.org>
@ 2007-08-24 15:23 ` Atsushi Nemoto
2007-08-28 15:05 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2007-08-24 15:23 UTC (permalink / raw)
To: linux-mips
On Fri, 24 Aug 2007 02:19:57 +0100, linux-mips@linux-mips.org wrote:
> Author: Ralf Baechle <ralf@linux-mips.org> Thu Aug 23 14:12:56 2007 +0100
> Commit: dda571e0032731ed05b65e365283c54522483b08
> Gitweb: http://www.linux-mips.org/g/linux/dda571e0
> Branch: master
>
> Since 96bde06a2df1b363206d3cdef53134b84ff37813 pcibios_fixup_bus's caller
> pci_scan_child_bus is no longer marked __devinit resulting in this modpost
> warning if PCI && !HOTPLUG:
And pci_read_bridge_bases() called by pcibios_fixup_bus is still
marked __devinit.
Should we drop __devinit from pci_read_bridge_bases() too?
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus.
2007-08-24 15:23 ` [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus Atsushi Nemoto
@ 2007-08-28 15:05 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-08-28 15:05 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips
On Sat, Aug 25, 2007 at 12:23:28AM +0900, Atsushi Nemoto wrote:
> On Fri, 24 Aug 2007 02:19:57 +0100, linux-mips@linux-mips.org wrote:
> > Author: Ralf Baechle <ralf@linux-mips.org> Thu Aug 23 14:12:56 2007 +0100
> > Commit: dda571e0032731ed05b65e365283c54522483b08
> > Gitweb: http://www.linux-mips.org/g/linux/dda571e0
> > Branch: master
> >
> > Since 96bde06a2df1b363206d3cdef53134b84ff37813 pcibios_fixup_bus's caller
> > pci_scan_child_bus is no longer marked __devinit resulting in this modpost
> > warning if PCI && !HOTPLUG:
>
> And pci_read_bridge_bases() called by pcibios_fixup_bus is still
> marked __devinit.
>
> Should we drop __devinit from pci_read_bridge_bases() too?
I already sent such a patch to gregkh on 23/8, so it'll just take a little
bit until this patch has propagated to Linus.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-28 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <S20023984AbXHXBUC/20070824012002Z+18840@ftp.linux-mips.org>
2007-08-24 15:23 ` [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus Atsushi Nemoto
2007-08-28 15:05 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox