[PATCH] Don't abort the build process if '-msym32' isn't supported

[PATCH] Don't abort the build process if '-msym32' isn't supported

[Franck Bui-Huu]

-msym32 and previously the strategy to tell the compiler to generate
64-bit code but the assembler to put it into 32-bit ELF was initially
a hack to get around the lack of proper 64-bit binutils support and
later turned into a neat optimization with significant code size
savings.  But it's really just an optimization so there is nothing
wrong with just dropping the option (and whatever else goes along with
it, I forgot all the nasty details) on the floor if due to a vintage
compiler it can't be suported.

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---

 Ralf,

 This patch is based on your linux-queue repository.
 Thanks for the commit message ;)

		Franck

 arch/mips/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index b0fac2d..ebd5d02 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -602,7 +602,9 @@ ifdef CONFIG_64BIT
   endif
 
   ifeq ($(KBUILD_SYM32), y)
-    cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+    ifeq ($(call cc-option-yn,-msym32), y)
+      cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+    endif
   endif
 endif
 
-- 
1.5.3.2

Re: [PATCH] Don't abort the build process if '-msym32' isn't supported

[Ralf Baechle]

On Thu, Sep 27, 2007 at 04:26:40PM +0200, Franck Bui-Huu wrote:

> -msym32 and previously the strategy to tell the compiler to generate
> 64-bit code but the assembler to put it into 32-bit ELF was initially
> a hack to get around the lack of proper 64-bit binutils support and
> later turned into a neat optimization with significant code size
> savings.  But it's really just an optimization so there is nothing
> wrong with just dropping the option (and whatever else goes along with
> it, I forgot all the nasty details) on the floor if due to a vintage
> compiler it can't be suported.
> 
> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
> ---
> 
>  Ralf,
> 
>  This patch is based on your linux-queue repository.
>  Thanks for the commit message ;)

Glad I'm useful for something ;-)

Queued for 2.6.24, thanks!

  Ralf