* [PATCH]v2 mips/ip32: enable PCI bridges
@ 2007-10-06 17:55 Giuseppe Sacco
2007-10-06 21:27 ` Ralf Baechle
2007-10-08 13:27 ` Maciej W. Rozycki
0 siblings, 2 replies; 3+ messages in thread
From: Giuseppe Sacco @ 2007-10-06 17:55 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Correct a typo in previous patch.
Signed-off-by: Giuseppe Sacco <eppesuig@debian.org>
---
Hi Ralf and linux-mips list,
I recompiled the kernel once again, after having update my git repository
and figured out an error in my previous patch. This should fix it.
Bye,
Giuseppe
diff --git a/arch/mips/pci/ops-mace.c b/arch/mips/pci/ops-mace.c
index 2025f1f..fe54514 100644
--- a/arch/mips/pci/ops-mace.c
+++ b/arch/mips/pci/ops-mace.c
@@ -33,7 +33,7 @@ static inline int mkaddr(struct pci_bus *bus, unsigned int devfn,
unsigned int reg)
{
return ((bus->number & 0xff) << 16) |
- (devfn & 0xff) << 8) |
+ ((devfn & 0xff) << 8) |
(reg & 0xfc);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH]v2 mips/ip32: enable PCI bridges
2007-10-06 17:55 [PATCH]v2 mips/ip32: enable PCI bridges Giuseppe Sacco
@ 2007-10-06 21:27 ` Ralf Baechle
2007-10-08 13:27 ` Maciej W. Rozycki
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2007-10-06 21:27 UTC (permalink / raw)
To: Giuseppe Sacco; +Cc: linux-mips
On Sat, Oct 06, 2007 at 07:55:03PM +0200, Giuseppe Sacco wrote:
> Correct a typo in previous patch.
Okay, applied.
Thanks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]v2 mips/ip32: enable PCI bridges
2007-10-06 17:55 [PATCH]v2 mips/ip32: enable PCI bridges Giuseppe Sacco
2007-10-06 21:27 ` Ralf Baechle
@ 2007-10-08 13:27 ` Maciej W. Rozycki
1 sibling, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2007-10-08 13:27 UTC (permalink / raw)
To: Giuseppe Sacco; +Cc: Ralf Baechle, linux-mips
On Sat, 6 Oct 2007, Giuseppe Sacco wrote:
> @@ -33,7 +33,7 @@ static inline int mkaddr(struct pci_bus *bus, unsigned int devfn,
> unsigned int reg)
> {
> return ((bus->number & 0xff) << 16) |
> - (devfn & 0xff) << 8) |
> + ((devfn & 0xff) << 8) |
> (reg & 0xfc);
> }
Bad formatting -- using correct one would make the typo more obvious
(ditto about the function's header).
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-08 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-06 17:55 [PATCH]v2 mips/ip32: enable PCI bridges Giuseppe Sacco
2007-10-06 21:27 ` Ralf Baechle
2007-10-08 13:27 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox