From: Michael Buesch <mb@bu3sch.de>
To: Steve Brown <sbrown@cortland.com>
Cc: "John W. Linville" <linville@tuxdriver.com>, linux-mips@linux-mips.org
Subject: Re: ohci-ssb driver on a Broadcom BCM5354
Date: Mon, 26 Nov 2007 15:15:42 +0100 [thread overview]
Message-ID: <200711261515.42501.mb@bu3sch.de> (raw)
In-Reply-To: <474AA87D.7000509@cortland.com>
On Monday 26 November 2007 12:05:33 Steve Brown wrote:
> Michael Buesch wrote:
> > On Sunday 18 November 2007 23:47:52 John W. Linville wrote:
> >
> >> You probably want to make Michael Buesch aware of this issue.
> >>
> >
> > I'm not sure anyone really tested this beyond some insmod tests.
> > I did not test this, as I don't have such a device.
> > So if you have any patches to fix this, please send them. I'm
> > certainly the wrong person who can fix this. ;)
> >
> >
> Adding the following at the end of ssb_ohci_attach seems to fix the problem.
>
> if (ssb_dma_set_mask(dev, DMA_32BIT_MASK))
> return -EOPNOTSUPP;
>
> I guessed at the dma mask. Would the code in the b43 driver that selects
> a dma mask be appropriate here?
I have no idea. If it makes it work, yeah. Cool. Let's add this.
--
Greetings Michael.
prev parent reply other threads:[~2007-11-26 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 18:23 ohci-ssb driver on a Broadcom BCM5354 Steve Brown
2007-11-18 19:53 ` Franck Bui-Huu
2007-11-18 22:47 ` John W. Linville
2007-11-19 18:23 ` Michael Buesch
2007-11-26 11:05 ` Steve Brown
2007-11-26 14:15 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711261515.42501.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=linux-mips@linux-mips.org \
--cc=linville@tuxdriver.com \
--cc=sbrown@cortland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox