Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] Fix ethernet interrupts for Cobalt RaQ1
@ 2008-01-11 23:25 Thomas Bogendoerfer
  2008-01-12  7:27 ` Martin Michlmayr
  2008-01-14  0:01 ` Ralf Baechle
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2008-01-11 23:25 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

RAQ1 uses the same interrupt routing as qube2.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---

 arch/mips/pci/fixup-cobalt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/pci/fixup-cobalt.c b/arch/mips/pci/fixup-cobalt.c
index f7df114..9553b14 100644
--- a/arch/mips/pci/fixup-cobalt.c
+++ b/arch/mips/pci/fixup-cobalt.c
@@ -177,7 +177,7 @@ static char irq_tab_raq2[] __initdata = {
 
 int __init pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
 {
-	if (cobalt_board_id < COBALT_BRD_ID_QUBE2)
+	if (cobalt_board_id <= COBALT_BRD_ID_QUBE1)
 		return irq_tab_qube1[slot];
 
 	if (cobalt_board_id == COBALT_BRD_ID_RAQ2)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix ethernet interrupts for Cobalt RaQ1
  2008-01-11 23:25 [PATCH] Fix ethernet interrupts for Cobalt RaQ1 Thomas Bogendoerfer
@ 2008-01-12  7:27 ` Martin Michlmayr
  2008-01-12  7:45   ` Martin Michlmayr
  2008-01-14  0:01 ` Ralf Baechle
  1 sibling, 1 reply; 4+ messages in thread
From: Martin Michlmayr @ 2008-01-12  7:27 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips, ralf

* Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2008-01-12 00:25]:
> RAQ1 uses the same interrupt routing as qube2.

I guess should be "as qube1"?

> -	if (cobalt_board_id < COBALT_BRD_ID_QUBE2)
> +	if (cobalt_board_id <= COBALT_BRD_ID_QUBE1)

-- 
Martin Michlmayr
http://www.cyrius.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix ethernet interrupts for Cobalt RaQ1
  2008-01-12  7:27 ` Martin Michlmayr
@ 2008-01-12  7:45   ` Martin Michlmayr
  0 siblings, 0 replies; 4+ messages in thread
From: Martin Michlmayr @ 2008-01-12  7:45 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips, ralf

* Martin Michlmayr <tbm@cyrius.com> [2008-01-12 08:27]:
> * Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2008-01-12 00:25]:
> > RAQ1 uses the same interrupt routing as qube2.
> I guess should be "as qube1"?

Never mind, your comment is correct.  Thanks for fixing this.
A lot of Debian users will be happy about this fix.
-- 
Martin Michlmayr
http://www.cyrius.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix ethernet interrupts for Cobalt RaQ1
  2008-01-11 23:25 [PATCH] Fix ethernet interrupts for Cobalt RaQ1 Thomas Bogendoerfer
  2008-01-12  7:27 ` Martin Michlmayr
@ 2008-01-14  0:01 ` Ralf Baechle
  1 sibling, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2008-01-14  0:01 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips

On Sat, Jan 12, 2008 at 12:25:14AM +0100, Thomas Bogendoerfer wrote:

> RAQ1 uses the same interrupt routing as qube2.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Applied with comment fix from Martin.

Thanks,

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-01-14  0:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-11 23:25 [PATCH] Fix ethernet interrupts for Cobalt RaQ1 Thomas Bogendoerfer
2008-01-12  7:27 ` Martin Michlmayr
2008-01-12  7:45   ` Martin Michlmayr
2008-01-14  0:01 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox