* [PATCH] Cobalt Qube1 has no serial port so don't use it
@ 2008-01-11 23:25 Thomas Bogendoerfer
2008-01-12 4:57 ` Yoichi Yuasa
2008-01-14 0:04 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2008-01-11 23:25 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
Because Qube1 doesn't have a serial chip waiting for transmit fifo empty
takes forever, which isn't a good idea. No prom_putchar/early console
for Qube1 fixes this.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/cobalt/console.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/mips/cobalt/console.c b/arch/mips/cobalt/console.c
index db330e8..d1ba701 100644
--- a/arch/mips/cobalt/console.c
+++ b/arch/mips/cobalt/console.c
@@ -4,10 +4,15 @@
#include <linux/io.h>
#include <linux/serial_reg.h>
+#include <cobalt.h>
+
#define UART_BASE ((void __iomem *)CKSEG1ADDR(0x1c800000))
void prom_putchar(char c)
{
+ if (cobalt_board_id <= COBALT_BRD_ID_QUBE1)
+ return;
+
while (!(readb(UART_BASE + UART_LSR) & UART_LSR_THRE))
;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Cobalt Qube1 has no serial port so don't use it
2008-01-11 23:25 [PATCH] Cobalt Qube1 has no serial port so don't use it Thomas Bogendoerfer
@ 2008-01-12 4:57 ` Yoichi Yuasa
2008-01-14 0:04 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Yoichi Yuasa @ 2008-01-12 4:57 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: yoichi_yuasa, linux-mips, ralf
On Sat, 12 Jan 2008 00:25:17 +0100 (CET)
Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> Because Qube1 doesn't have a serial chip waiting for transmit fifo empty
> takes forever, which isn't a good idea. No prom_putchar/early console
> for Qube1 fixes this.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Acked-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> ---
>
> arch/mips/cobalt/console.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/cobalt/console.c b/arch/mips/cobalt/console.c
> index db330e8..d1ba701 100644
> --- a/arch/mips/cobalt/console.c
> +++ b/arch/mips/cobalt/console.c
> @@ -4,10 +4,15 @@
> #include <linux/io.h>
> #include <linux/serial_reg.h>
>
> +#include <cobalt.h>
> +
> #define UART_BASE ((void __iomem *)CKSEG1ADDR(0x1c800000))
>
> void prom_putchar(char c)
> {
> + if (cobalt_board_id <= COBALT_BRD_ID_QUBE1)
> + return;
> +
> while (!(readb(UART_BASE + UART_LSR) & UART_LSR_THRE))
> ;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Cobalt Qube1 has no serial port so don't use it
2008-01-11 23:25 [PATCH] Cobalt Qube1 has no serial port so don't use it Thomas Bogendoerfer
2008-01-12 4:57 ` Yoichi Yuasa
@ 2008-01-14 0:04 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-01-14 0:04 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips
On Sat, Jan 12, 2008 at 12:25:17AM +0100, Thomas Bogendoerfer wrote:
> Because Qube1 doesn't have a serial chip waiting for transmit fifo empty
> takes forever, which isn't a good idea. No prom_putchar/early console
> for Qube1 fixes this.
Applied, too.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-14 0:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-11 23:25 [PATCH] Cobalt Qube1 has no serial port so don't use it Thomas Bogendoerfer
2008-01-12 4:57 ` Yoichi Yuasa
2008-01-14 0:04 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox