* [PATCH] [MIPS]: constify function pointer tables [not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de> @ 2008-01-22 19:42 ` Jan Engelhardt 2008-01-23 0:32 ` Ralf Baechle 2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst 0 siblings, 2 replies; 3+ messages in thread From: Jan Engelhardt @ 2008-01-22 19:42 UTC (permalink / raw) To: Ralf Baechle; +Cc: linux-mips Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de> --- arch/mips/basler/excite/excite_iodev.c | 2 +- arch/mips/kernel/proc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/basler/excite/excite_iodev.c b/arch/mips/basler/excite/excite_iodev.c index 6af0b21..476d20e 100644 --- a/arch/mips/basler/excite/excite_iodev.c +++ b/arch/mips/basler/excite/excite_iodev.c @@ -48,7 +48,7 @@ static DECLARE_WAIT_QUEUE_HEAD(wq); -static struct file_operations fops = +static const struct file_operations fops = { .owner = THIS_MODULE, .open = iodev_open, diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c index 6e6e947..f30e035 100644 --- a/arch/mips/kernel/proc.c +++ b/arch/mips/kernel/proc.c @@ -89,7 +89,7 @@ static void c_stop(struct seq_file *m, void *v) { } -struct seq_operations cpuinfo_op = { +const struct seq_operations cpuinfo_op = { .start = c_start, .next = c_next, .stop = c_stop, -- 1.5.3.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [MIPS]: constify function pointer tables 2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt @ 2008-01-23 0:32 ` Ralf Baechle 2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst 1 sibling, 0 replies; 3+ messages in thread From: Ralf Baechle @ 2008-01-23 0:32 UTC (permalink / raw) To: Jan Engelhardt; +Cc: linux-mips On Tue, Jan 22, 2008 at 08:42:33PM +0100, Jan Engelhardt wrote: Thanks, queued for 2.6.25. Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR 2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt 2008-01-23 0:32 ` Ralf Baechle @ 2008-02-07 12:41 ` peter fuerst 1 sibling, 0 replies; 3+ messages in thread From: peter fuerst @ 2008-02-07 12:41 UTC (permalink / raw) To: Ralf Baechle; +Cc: linux-mips With commit db38501511a7513ec4f0ae9922d847c135cf3c78 PAGE_OFFSET was redefined as CAC_BASE+PHYS_OFFSET, but [UN]CAC_ADDR - which are used in dma_alloc_coherent() and dma_free_coherent() respectively, and in drivers/video/au1100fb.c - were not adjusted accordingly. with kind regards Signed-off-by: peter fuerst <post@pfrst.de> --- a/linux-2.6.24/include/asm-mips/page.h Fri Jan 25 12:23:51 2008 +++ b/linux-2.6.24/include/asm-mips/page.h Wed Feb 6 23:26:31 2008 @@ -184,8 +184,8 @@ #define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \ VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) -#define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + UNCAC_BASE) -#define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET) +#define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + PHYS_OFFSET + UNCAC_BASE) +#define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET - PHYS_OFFSET) #include <asm-generic/memory_model.h> #include <asm-generic/page.h> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-07 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54038cd4f87a03884e4f59f8f3697889dfb63c54.1201030614.git.jengelh@computergmbh.de>
2008-01-22 19:42 ` [PATCH] [MIPS]: constify function pointer tables Jan Engelhardt
2008-01-23 0:32 ` Ralf Baechle
2008-02-07 12:41 ` [PATCH] [MIPS]: fix CAC_ADDR/UNCAC_ADDR peter fuerst
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox