From: Ralf Baechle <ralf@linux-mips.org>
To: Adrian Bunk <adrian.bunk@movial.fi>
Cc: Chris Dearman <chris@mips.com>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] MIPS SEAD compile fix
Date: Mon, 26 May 2008 23:43:42 +0100 [thread overview]
Message-ID: <20080526224342.GA28360@linux-mips.org> (raw)
In-Reply-To: <20080525180316.GF1791@cs181133002.pp.htv.fi>
On Sun, May 25, 2008 at 09:03:16PM +0300, Adrian Bunk wrote:
> This patch fixes the following compile error caused by
> commit 39b8d5254246ac56342b72f812255c8f7a74dca9
> ([MIPS] Add support for MIPS CMP platform.):
>
> <-- snip -->
>
> ...
> CC arch/mips/mips-boards/generic/time.o
> cc1: warnings being treated as errors
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/mips-boards/generic/time.c:63: error: 'ledbitmask' defined but not used
> make[2]: *** [arch/mips/mips-boards/generic/time.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
> ---
> a6622e47dd128da338d6dbae457ec1b043604814 diff --git a/arch/mips/mips-boards/generic/time.c b/arch/mips/mips-boards/generic/time.c
> index 008fd82..df23558 100644
> --- a/arch/mips/mips-boards/generic/time.c
> +++ b/arch/mips/mips-boards/generic/time.c
[...]
> +#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)
Generic code thanks to #ifdef ;-) Not really the way to go. I just blew
away the original offending change.
Ralf
prev parent reply other threads:[~2008-05-26 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 18:03 [2.6 patch] MIPS SEAD compile fix Adrian Bunk
2008-05-26 22:43 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526224342.GA28360@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=adrian.bunk@movial.fi \
--cc=anemo@mba.ocn.ne.jp \
--cc=chris@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox