* [2.6 patch] MIPS SEAD compile fix
@ 2008-05-25 18:03 Adrian Bunk
2008-05-26 22:43 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-05-25 18:03 UTC (permalink / raw)
To: Chris Dearman, Atsushi Nemoto, Ralf Baechle; +Cc: linux-mips, linux-kernel
This patch fixes the following compile error caused by
commit 39b8d5254246ac56342b72f812255c8f7a74dca9
([MIPS] Add support for MIPS CMP platform.):
<-- snip -->
...
CC arch/mips/mips-boards/generic/time.o
cc1: warnings being treated as errors
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/mips-boards/generic/time.c:63: error: 'ledbitmask' defined but not used
make[2]: *** [arch/mips/mips-boards/generic/time.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
a6622e47dd128da338d6dbae457ec1b043604814 diff --git a/arch/mips/mips-boards/generic/time.c b/arch/mips/mips-boards/generic/time.c
index 008fd82..df23558 100644
--- a/arch/mips/mips-boards/generic/time.c
+++ b/arch/mips/mips-boards/generic/time.c
@@ -58,10 +58,14 @@ static int mips_cpu_timer_irq;
static int mips_cpu_perf_irq;
extern int cp0_perfcount_irq;
+#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)
+
DEFINE_PER_CPU(unsigned int, tickcount);
#define tickcount_this_cpu __get_cpu_var(tickcount)
static unsigned long ledbitmask;
+#endif
+
static void mips_timer_dispatch(void)
{
#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] MIPS SEAD compile fix
2008-05-25 18:03 [2.6 patch] MIPS SEAD compile fix Adrian Bunk
@ 2008-05-26 22:43 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2008-05-26 22:43 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Chris Dearman, Atsushi Nemoto, linux-mips, linux-kernel
On Sun, May 25, 2008 at 09:03:16PM +0300, Adrian Bunk wrote:
> This patch fixes the following compile error caused by
> commit 39b8d5254246ac56342b72f812255c8f7a74dca9
> ([MIPS] Add support for MIPS CMP platform.):
>
> <-- snip -->
>
> ...
> CC arch/mips/mips-boards/generic/time.o
> cc1: warnings being treated as errors
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/mips-boards/generic/time.c:63: error: 'ledbitmask' defined but not used
> make[2]: *** [arch/mips/mips-boards/generic/time.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
> ---
> a6622e47dd128da338d6dbae457ec1b043604814 diff --git a/arch/mips/mips-boards/generic/time.c b/arch/mips/mips-boards/generic/time.c
> index 008fd82..df23558 100644
> --- a/arch/mips/mips-boards/generic/time.c
> +++ b/arch/mips/mips-boards/generic/time.c
[...]
> +#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)
Generic code thanks to #ifdef ;-) Not really the way to go. I just blew
away the original offending change.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-26 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-25 18:03 [2.6 patch] MIPS SEAD compile fix Adrian Bunk
2008-05-26 22:43 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox