* [PATCH] Fix IP32 unexpected irq 71
@ 2008-06-23 22:48 Thomas Bogendoerfer
2008-06-26 7:31 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2008-06-23 22:48 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
It's possible that the crime interrupt handler is called without
pending interrupts (probably a hardware issue). To avoid irritating
"unexpected irq 71" messages, we now just ignore the spurious crime
interrupts.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/sgi-ip32/ip32-irq.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/mips/sgi-ip32/ip32-irq.c b/arch/mips/sgi-ip32/ip32-irq.c
index b0ea0e4..0d6b666 100644
--- a/arch/mips/sgi-ip32/ip32-irq.c
+++ b/arch/mips/sgi-ip32/ip32-irq.c
@@ -425,6 +425,11 @@ static void ip32_irq0(void)
BUILD_BUG_ON(MACEISA_SERIAL2_RDMAOR_IRQ - MACEISA_AUDIO_SW_IRQ != 31);
crime_int = crime->istat & crime_mask;
+
+ /* crime sometime delivers spurious interrupts, ignore them */
+ if (unlikely(crime_int == 0))
+ return;
+
irq = MACE_VID_IN1_IRQ + __ffs(crime_int);
if (crime_int & CRIME_MACEISA_INT_MASK) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix IP32 unexpected irq 71
2008-06-23 22:48 [PATCH] Fix IP32 unexpected irq 71 Thomas Bogendoerfer
@ 2008-06-26 7:31 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2008-06-26 7:31 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips
On Tue, Jun 24, 2008 at 12:48:05AM +0200, Thomas Bogendoerfer wrote:
> It's possible that the crime interrupt handler is called without
> pending interrupts (probably a hardware issue). To avoid irritating
> "unexpected irq 71" messages, we now just ignore the spurious crime
> interrupts.
Applied, thanks!
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-26 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 22:48 [PATCH] Fix IP32 unexpected irq 71 Thomas Bogendoerfer
2008-06-26 7:31 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox