Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] Remove mips_machtype from EMMA2RH machines
@ 2008-07-14 13:54 Thomas Bogendoerfer
  2008-07-14 14:13 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2008-07-14 13:54 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

This is the EMMA2RH part of the mips_machtype removal.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---

This patch is against the queue tree.

 arch/mips/emma2rh/common/prom.c |   15 +++++++--------
 include/asm-mips/bootinfo.h     |    5 -----
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/arch/mips/emma2rh/common/prom.c b/arch/mips/emma2rh/common/prom.c
index 0f791eb..38ce477 100644
--- a/arch/mips/emma2rh/common/prom.c
+++ b/arch/mips/emma2rh/common/prom.c
@@ -34,12 +34,11 @@
 
 const char *get_system_type(void)
 {
-	switch (mips_machtype) {
-	case MACH_NEC_MARKEINS:
-		return "NEC EMMA2RH Mark-eins";
-	default:
-		return "Unknown NEC board";
-	}
+#if defined(CONFIG_MARKEINS)
+	return "NEC EMMA2RH Mark-eins";
+#else
+#error  "Unknown NEC board";
+#endif
 }
 
 /* [jsun@junsun.net] PMON passes arguments in C main() style */
@@ -63,10 +62,10 @@ void __init prom_init(void)
 	}
 
 #if defined(CONFIG_MARKEINS)
-	mips_machtype = MACH_NEC_MARKEINS;
 	add_memory_region(0, EMMA2RH_RAM_SIZE, BOOT_MEM_RAM);
+#else
+#error  "Unknown NEC board";
 #endif
-
 }
 
 void __init prom_free_prom_memory(void)
diff --git a/include/asm-mips/bootinfo.h b/include/asm-mips/bootinfo.h
index 653096a..51dbec9 100644
--- a/include/asm-mips/bootinfo.h
+++ b/include/asm-mips/bootinfo.h
@@ -47,11 +47,6 @@
 #define  MACH_LASAT_200		1	/* Masquerade PRO/SP200 */
 
 /*
- * Valid machtype for group NEC EMMA2RH
- */
-#define  MACH_NEC_MARKEINS	0	/* NEC EMMA2RH Mark-eins	*/
-
-/*
  * Valid machtype for group PMC-MSP
  */
 #define MACH_MSP4200_EVAL       0	/* PMC-Sierra MSP4200 Evaluation */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove mips_machtype from EMMA2RH machines
  2008-07-14 13:54 [PATCH] Remove mips_machtype from EMMA2RH machines Thomas Bogendoerfer
@ 2008-07-14 14:13 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2008-07-14 14:13 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips

On Mon, Jul 14, 2008 at 03:54:30PM +0200, Thomas Bogendoerfer wrote:

> +#error  "Unknown NEC board";

No quotes, no trailing semikolons in a #error statement - they actually
are part of the string in #error which will look like this:

$ cat c.c 
#error  "Unknown NEC board";
$ gcc -o c.o c.c
c.c:1:2: error: #error "Unknown NEC board";
$

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-14 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-14 13:54 [PATCH] Remove mips_machtype from EMMA2RH machines Thomas Bogendoerfer
2008-07-14 14:13 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox