From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
rtc-linux@googlegroups.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] DS1286: new RTC driver
Date: Thu, 7 Aug 2008 10:12:33 +0100 [thread overview]
Message-ID: <20080807091233.GA10389@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0808071102420.23641@anakin>
On Thu, Aug 07, 2008 at 11:03:07AM +0200, Geert Uytterhoeven wrote:
> > > + priv = kzalloc(sizeof *priv, GFP_KERNEL);
> >
> > sizeof(struct ds1286_priv) is a little bit cleaner.
>
> What if the type of priv changes?
Then this code will more changes anyway ...
Ralf
next prev parent reply other threads:[~2008-08-07 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 17:41 [PATCH] DS1286: new RTC driver Thomas Bogendoerfer
2008-08-03 22:20 ` Ralf Baechle
2008-08-07 8:52 ` Alessandro Zummo
2008-08-07 9:03 ` Geert Uytterhoeven
2008-08-07 9:12 ` Ralf Baechle [this message]
2008-08-07 9:12 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807091233.GA10389@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alessandro.zummo@towertech.it \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=rtc-linux@googlegroups.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox