From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
rtc-linux@googlegroups.com, linux-mips@linux-mips.org,
ralf@linux-mips.org
Subject: Re: [PATCH] DS1286: new RTC driver
Date: Thu, 7 Aug 2008 11:03:07 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0808071102420.23641@anakin> (raw)
In-Reply-To: <20080807105249.50d6e777@i1501.lan.towertech.it>
On Thu, 7 Aug 2008, Alessandro Zummo wrote:
> On Sun, 3 Aug 2008 19:41:37 +0200 (CEST)
> Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> > +static int __devinit ds1286_probe(struct platform_device *pdev)
> > +{
> > + struct rtc_device *rtc;
> > + struct resource *res;
> > + struct ds1286_priv *priv;
> > + int ret = 0;
> > +
> > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + if (!res)
> > + return -ENODEV;
> > + priv = kzalloc(sizeof *priv, GFP_KERNEL);
>
> sizeof(struct ds1286_priv) is a little bit cleaner.
What if the type of priv changes?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-08-07 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 17:41 [PATCH] DS1286: new RTC driver Thomas Bogendoerfer
2008-08-03 22:20 ` Ralf Baechle
2008-08-07 8:52 ` Alessandro Zummo
2008-08-07 9:03 ` Geert Uytterhoeven [this message]
2008-08-07 9:12 ` Ralf Baechle
2008-08-07 9:12 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0808071102420.23641@anakin \
--to=geert@linux-m68k.org \
--cc=alessandro.zummo@towertech.it \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rtc-linux@googlegroups.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox