"indy_volume_button" [sound/oss/hal2.ko] undefined

"indy_volume_button" [sound/oss/hal2.ko] undefined

[Martin Michlmayr]

sound/oss/hal2.ko fails to build because indy_volume_button was
removed from the IP22 code.  Is sound/oss/hal2o going to be removed
before 2.6.27 is out?

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: "indy_volume_button" [sound/oss/hal2.ko] undefined

[Thomas Bogendoerfer]

On Wed, Aug 13, 2008 at 03:59:55PM +0300, Martin Michlmayr wrote:
> sound/oss/hal2.ko fails to build because indy_volume_button was
> removed from the IP22 code.  Is sound/oss/hal2o going to be removed
> before 2.6.27 is out?

The OSS hal driver is still marked experimental and the only IP22 sound
driver I'll care (and take care) is the alsa one. So if nobody objects
I'll send a remove patch.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

Re: "indy_volume_button" [sound/oss/hal2.ko] undefined

[Martin Michlmayr]

* Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2008-08-13 22:58]:
> > sound/oss/hal2.ko fails to build because indy_volume_button was
> > removed from the IP22 code.  Is sound/oss/hal2o going to be removed
> > before 2.6.27 is out?
> 
> The OSS hal driver is still marked experimental and the only IP22 sound
> driver I'll care (and take care) is the alsa one. So if nobody objects
> I'll send a remove patch.

Well, it got broken by your ALSA related changes.  Anyway, I'm all for
removing it, but it should happen before 2.6.27 is out so there's no
regression.

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: "indy_volume_button" [sound/oss/hal2.ko] undefined

[Thomas Bogendoerfer]

On Thu, Aug 14, 2008 at 08:41:53AM +0300, Martin Michlmayr wrote:
> Well, it got broken by your ALSA related changes.

I consider it semantically broken before I even touched it.

> Anyway, I'm all for removing it, but it should happen before 2.6.27 is
> out so there's no regression.

I'll send a remove path later. The second option would be to just
remove the indy_volume_button code from the OSS driver.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

Re: "indy_volume_button" [sound/oss/hal2.ko] undefined

[Martin Michlmayr]

* Thomas Bogendoerfer <tsbogend@alpha.franken.de> [2008-08-14 08:37]:
> > Anyway, I'm all for removing it, but it should happen before 2.6.27 is
> > out so there's no regression.
> 
> I'll send a remove path later. The second option would be to just
> remove the indy_volume_button code from the OSS driver.

I'd just get rid of the whole driver.

Thanks for writing the new one, btw.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: Re: "indy_volume_button" [sound/oss/hal2.ko] undefined

[Markus Gothe]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Thomas Bogendoerfer wrote:
> On Wed, Aug 13, 2008 at 03:59:55PM +0300, Martin Michlmayr wrote:
>> sound/oss/hal2.ko fails to build because indy_volume_button was
>> removed from the IP22 code.  Is sound/oss/hal2o going to be removed
>> before 2.6.27 is out?
>
> The OSS hal driver is still marked experimental and the only IP22 sound
> driver I'll care (and take care) is the alsa one. So if nobody objects
> I'll send a remove patch.
>
> Thomas.
>
I'm in favor of just maintaining the ALSA one... Let's get rid of the
OSS one since probably there is very little interest in using it...

//Markus

- --
_______________________________________

Mr Markus Gothe
Software Engineer

Phone: +46 (0)13 21 81 20 (ext. 1046)
Fax: +46 (0)13 21 21 15
Mobile: +46 (0)70 348 44 35
Diskettgatan 11, SE-583 35 Linköping, Sweden
www.27m.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIo9EE6I0XmJx2NrwRCK6HAJkBFgkt7iZ/qw4aZSKVNtjCsnK6GgCfZ69P
FxqjlaeL73885ImVhNnL3hA=
=vb+4
-----END PGP SIGNATURE-----