* [PATCH 5/6] rb532: replace volatile rough read with a readl
@ 2008-08-21 22:15 Florian Fainelli
0 siblings, 0 replies; only message in thread
From: Florian Fainelli @ 2008-08-21 22:15 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
This patch replaces a rough read using volatiles
with a readl.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index 3d1632c..d44a703 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -70,7 +70,7 @@ void set_434_reg(unsigned reg_offs, unsigned bit, unsigned len, unsigned val)
spin_lock_irqsave(&dev3.lock, flags);
- data = *(volatile unsigned *) (IDT434_REG_BASE + reg_offs);
+ data = readl(IDT434_REG_BASE + reg_offs);
for (i = 0; i != len; ++i) {
if (val & (1 << i))
data |= (1 << (i + bit));
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-21 22:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 22:15 [PATCH 5/6] rb532: replace volatile rough read with a readl Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox