* [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.
@ 2008-10-10 19:40 David Daney
2008-10-11 7:41 ` Geert Uytterhoeven
2008-10-11 14:57 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: David Daney @ 2008-10-10 19:40 UTC (permalink / raw)
To: linux-mips; +Cc: Paoletti, Tomaso
Add missing include in arch/mips/include/asm/ptrace.h.
Recent reorganization seems to have lost this include. You cannot
build without it.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com>
---
arch/mips/include/asm/ptrace.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index 7fe9812..36872b8 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -120,6 +120,8 @@ struct pt_watch_regs {
#include <linux/compiler.h>
#include <linux/linkage.h>
+#include <linux/sched.h>
+
#include <asm/isadep.h>
extern int ptrace_getregs(struct task_struct *child, __s64 __user *data);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.
2008-10-10 19:40 [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h David Daney
@ 2008-10-11 7:41 ` Geert Uytterhoeven
2008-10-11 14:57 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2008-10-11 7:41 UTC (permalink / raw)
To: David Daney; +Cc: linux-mips, Paoletti, Tomaso
On Fri, 10 Oct 2008, David Daney wrote:
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7fe9812..36872b8 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -120,6 +120,8 @@ struct pt_watch_regs {
>
> #include <linux/compiler.h>
^
> #include <linux/linkage.h>
^
> +#include <linux/sched.h>
> +
> #include <asm/isadep.h>
^
>
^
> extern int ptrace_getregs(struct task_struct *child, __s64 __user *data);
^
Oops, you mailer removed some spaces again...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.
2008-10-10 19:40 [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h David Daney
2008-10-11 7:41 ` Geert Uytterhoeven
@ 2008-10-11 14:57 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-10-11 14:57 UTC (permalink / raw)
To: David Daney; +Cc: linux-mips, Paoletti, Tomaso
On Fri, Oct 10, 2008 at 12:40:14PM -0700, David Daney wrote:
> Add missing include in arch/mips/include/asm/ptrace.h.
>
> Recent reorganization seems to have lost this include. You cannot
> build without it.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7fe9812..36872b8 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -120,6 +120,8 @@ struct pt_watch_regs {
>
> #include <linux/compiler.h>
> #include <linux/linkage.h>
> +#include <linux/sched.h>
Sched.h is one of those include files that drag in way to many other
header files. So I went for a forward declaration of struct task_struct
instead.
Thanks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-11 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-10 19:40 [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h David Daney
2008-10-11 7:41 ` Geert Uytterhoeven
2008-10-11 14:57 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox