From: Ralf Baechle <ralf@linux-mips.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-mips <linux-mips@linux-mips.org>,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH][MIPS] fix kgdb build error
Date: Fri, 24 Oct 2008 17:42:41 +0100 [thread overview]
Message-ID: <20081024164241.GB21892@linux-mips.org> (raw)
In-Reply-To: <20081025001725.7ac18a1b.yoichi_yuasa@tripeaks.co.jp>
On Sat, Oct 25, 2008 at 12:17:25AM +0900, Yoichi Yuasa wrote:
> ptrace.h needs #include <linux/types.h>
>
> In file included from include/linux/ptrace.h:49,
> from arch/mips/kernel/kgdb.c:25:
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:83: error: expected specifier-qualifier-list before 'uint32_t'
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:98: error: expected specifier-qualifier-list before 'uint64_t'
> In file included from include/linux/ptrace.h:49,
> from arch/mips/kernel/kgdb.c:25:
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:123: error: expected declaration specifiers or '...' before '__s64'
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:124: error: expected declaration specifiers or '...' before '__s64'
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:126: error: expected declaration specifiers or '...' before '__u32'
> /home/yuasa/src/linux/test/generic/linux/arch/mips/include/asm/ptrace.h:127: error: expected declaration specifiers or '...' before '__u32'
> make[1]: *** [arch/mips/kernel/kgdb.o] Error 1
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
<asm/ptrace.h> is exported to userland so we can't include these types.
Basically <linux/types.h> or <stdint.h> are polluting the namespace. So
either we use some __* type and include only those or we get entirely
rid of typedef'ed types - as in the patch that you've posted while I was
writing this.
Ralf
next prev parent reply other threads:[~2008-10-24 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 15:17 [PATCH][MIPS] fix kgdb build error Yoichi Yuasa
2008-10-24 16:31 ` David Daney
2008-10-24 17:09 ` Ralf Baechle
2008-10-24 17:18 ` David Daney
2008-10-24 16:42 ` Ralf Baechle [this message]
2008-10-25 8:30 ` Yoichi Yuasa
2008-10-25 18:20 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024164241.GB21892@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox