From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][MIPS] fix kgdb build error
Date: Fri, 24 Oct 2008 18:09:50 +0100 [thread overview]
Message-ID: <20081024170950.GC25297@linux-mips.org> (raw)
In-Reply-To: <4901F851.8010103@caviumnetworks.com>
On Fri, Oct 24, 2008 at 09:31:13AM -0700, David Daney wrote:
> Yoichi Yuasa wrote:
>> ptrace.h needs #include <linux/types.h>
>>
> [...]
>
> Can you try this completely untested patch instead?
>
> If it works, I will give it a more thorough test over the next few
> weeks.
This looks correct, I think.
Though I was wondering about two special cases:
o 32-bit debugger debugging a 64-bit process
o 64-bit debugger debugging a 32-bit process
The unions make we wonder if that case was considered ...
Anyway, your patch certainly solves Yoichi's original bug so I'll apply it.
Ralf
next prev parent reply other threads:[~2008-10-24 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 15:17 [PATCH][MIPS] fix kgdb build error Yoichi Yuasa
2008-10-24 16:31 ` David Daney
2008-10-24 17:09 ` Ralf Baechle [this message]
2008-10-24 17:18 ` David Daney
2008-10-24 16:42 ` Ralf Baechle
2008-10-25 8:30 ` Yoichi Yuasa
2008-10-25 18:20 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024170950.GC25297@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox