From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: julia@diku.dk
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap
Date: Wed, 16 Sep 2009 00:45:25 +0900 (JST) [thread overview]
Message-ID: <20090916.004525.74746264.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.0909150701170.11392@ask.diku.dk>
On Tue, 15 Sep 2009 07:03:42 +0200 (CEST), Julia Lawall <julia@diku.dk> wrote:
> > +out_pdev:
> > + platform_device_put(pdev);
> > +out_gpio:
> > + gpio_remove(&iocled->chip);
>
> I just noticed that the prototype of gpio_remove has __must_check
> I don't think there is anything to check here; since the thing is not
> fully initialized here, it is unlikely to be busy. Should there be (void)
> in front of it?
The void casting does not silence the warning. How about this?
if (gpiochip_remove(&iocled->chip))
return;
In general, memory leak would be less serious than crash or data
corruption ;)
---
Atsushi Nemoto
next prev parent reply other threads:[~2009-09-15 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 16:21 [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap Julia Lawall
2009-09-13 14:25 ` Atsushi Nemoto
2009-09-13 15:14 ` Julia Lawall
2009-09-13 15:33 ` Atsushi Nemoto
2009-09-13 15:49 ` Julia Lawall
2009-09-13 19:15 ` Julia Lawall
2009-09-14 14:56 ` Ralf Baechle
2009-09-15 5:03 ` Julia Lawall
2009-09-15 15:45 ` Atsushi Nemoto [this message]
2009-09-15 15:47 ` Julia Lawall
2009-09-15 15:56 ` Julia Lawall
2009-09-15 14:02 ` Ralf Rösch
2009-09-15 14:35 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916.004525.74746264.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox